Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp392169ybl; Thu, 15 Aug 2019 20:00:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqy7IIddY3dpE5sctfitQESDR7ejtIF0DAOZC2FMlRW8rlJxkPnp6LQEDjfKDjfEIS+dHfGa X-Received: by 2002:a63:553:: with SMTP id 80mr6110260pgf.280.1565924429674; Thu, 15 Aug 2019 20:00:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565924429; cv=none; d=google.com; s=arc-20160816; b=q/AXnXC8dMYSebdanWF+5MSBRKFkWq1eBA4GXiS3dtatmrZVLvbau9D1MCepNOXgtn AKHyuyGcGVcXsU4z2c3T3gc0ZL5KVsaiffvjUcVLRNiubb+QQQ0hFRo2++2GMkrjJgzy rellNvSio58wfqr59W7EGByK17tZKBIxeiv/tlq7yZ1guKfYmrT3mg1BzBGSkourL4kH MdtGTIolQScheNeMvgR03oxGZcnMyDznD/SMyAL4yLSXoZqFwsF3vBDNykbSjUIaqO7j Cr9eDQdZkGZeCuPebaX4sbh2Diea2b4oDZZ94V4nYxYDc8KC3/V0RXN40lVoiGFF7XJ5 Tk+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=USpfkdYkRqf8xAyUNcxqMtcg+noJ6YgrrRrqW5FspOU=; b=zFa4JiSPlNM9zbLK9unfqri55Glz+37QAXQxgs6vnAToSswwhfTLAczZ7U5yUXYeaK H84nZrW/PNN+ji3DJjUFrfiHNOFOE3HOHadgneOynatCVTaWaLyIW0xFyQZ/OvRyxWDn QNVIlAh2o+Rt1bsj0AwdI/kvCsaf6sBr2SergPRKJH38jzmCTq6G1npyUK5S81J4bfOz qN8ri4p4cc0cYCu3zwcNNxTeSRMynaEH/vSSCPDsQ7mLpXhJB5Z82UBTlPQpLZmmEP/g +xd4KNO6YhsgrZEvX8qWeS7hTlZQJMTSAOOheGREEfkpSKag35ejfNsDliWp7GzxLQ7p u38A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33si470282plb.415.2019.08.15.20.00.13; Thu, 15 Aug 2019 20:00:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbfHPC71 convert rfc822-to-8bit (ORCPT + 99 others); Thu, 15 Aug 2019 22:59:27 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:52971 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfHPC70 (ORCPT ); Thu, 15 Aug 2019 22:59:26 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x7G2xI8R019537, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (RTITCASV01.realtek.com.tw[172.21.6.18]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x7G2xI8R019537 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 16 Aug 2019 10:59:18 +0800 Received: from RTITMBSVM03.realtek.com.tw ([fe80::e1fe:b2c1:57ec:f8e1]) by RTITCASV01.realtek.com.tw ([::1]) with mapi id 14.03.0468.000; Fri, 16 Aug 2019 10:59:17 +0800 From: Hayes Wang To: David Miller CC: "netdev@vger.kernel.org" , nic_swsd , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net-next] r8152: divide the tx and rx bottom functions Thread-Topic: [PATCH net-next] r8152: divide the tx and rx bottom functions Thread-Index: AQHVUnqNDBLFc1N41kCW+rl5DeKpGqb8LWmAgADnKaA= Date: Fri, 16 Aug 2019 02:59:16 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F18D43A3@RTITMBSVM03.realtek.com.tw> References: <1394712342-15778-301-Taiwan-albertk@realtek.com> <20190815.135851.1942927063321516679.davem@davemloft.net> In-Reply-To: <20190815.135851.1942927063321516679.davem@davemloft.net> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.214] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller [mailto:davem@davemloft.net] > Sent: Friday, August 16, 2019 4:59 AM [...] > Theoretically, yes. > > But do you have actual performance numbers showing this to be worth > the change? > > Always provide performance numbers with changes that are supposed to > improve performance. On x86, they are almost the same. Tx/Rx: 943/943 Mbits/sec -> 945/944 For arm platform, Tx/Rx: 917/917 Mbits/sec -> 933/933 Improve about 1.74%. Best Regards, Hayes