Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp458154ybl; Thu, 15 Aug 2019 21:42:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdLbqeRYF+KTtzOlKi9Ubtl5Rv3AuWN4PDFoCl/LLclYdHjME6uUAf+w6uf9SZc6nYZLq1 X-Received: by 2002:a17:90a:3ad0:: with SMTP id b74mr5284350pjc.79.1565930575111; Thu, 15 Aug 2019 21:42:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565930575; cv=none; d=google.com; s=arc-20160816; b=z9LbikEumdsExSjl3CgoqoyrFn3ETvT23wLHhOrWZomgwRn7W9SRW5ugIZdY0IFCqy CyP0lEJKuhsc+RTB3gwDL0ZEb+k/uqKbuh7dPDbWFFOH2YXGvMvGtMnOyekzP85JrMMU 8OV55azmUXJ2oiTGwRqygRJrSLDcpLa1VDGs3c4LwqaylaoxuqUoUCUnRQdEp9U3GqfN Hqlb4jNVOuyMCMNmqPNeJCbeB/h0j9Qh77GWVKlrtvOz3EknOyPChZuMVoxs3zlt08GW TS6V/boTzCKDatndevuMoHenuGQ84fjjPfbTMe18nLXLwiZauNEsYpLJKppLHregw3tj ee7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=esRgC3YGrqXweWWtbMZLdg8XjRH1f7spfhHv+QnHf0Y=; b=y+mp+aA+Z6IQ4Z0uXx3KYXXh1h3yPc9RbcIuemFpi2uaxANGOxH9daYYSl0T94bRst 83rvCIJHzFFYF75jlgiuaHl2Yst2pyn99jK83Y97cvHrIoj7Jd45r5SnmnhFAbzQyoxP J9L9RaON1ZuAfTuvnbbKx3zJaR14f5TaGWDzEqV/NEm8gFzLomOAfgNf0K/Du8rWCjx6 l4nvHQOqgWHhYU+ameAdQrVy0giStUpkT2EztCa38i3zreYKWN89xHBcaE4AufVysM4u eq+bnzhQcajygUFn+z1jq4lLLo9+LqVwPpAldRJdgHbfWw1lRdneglfxqxl6WAVluZgF loaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 39si3281492plc.377.2019.08.15.21.42.37; Thu, 15 Aug 2019 21:42:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbfHPEll (ORCPT + 99 others); Fri, 16 Aug 2019 00:41:41 -0400 Received: from verein.lst.de ([213.95.11.211]:51981 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725897AbfHPEll (ORCPT ); Fri, 16 Aug 2019 00:41:41 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CA0E568AFE; Fri, 16 Aug 2019 06:41:37 +0200 (CEST) Date: Fri, 16 Aug 2019 06:41:37 +0200 From: Christoph Hellwig To: Jerome Glisse Cc: Dan Williams , Jason Gunthorpe , Christoph Hellwig , Ben Skeggs , Felix Kuehling , Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 04/15] mm: remove the pgmap field from struct hmm_vma_walk Message-ID: <20190816044137.GA4093@lst.de> References: <20190808065933.GA29382@lst.de> <20190814073854.GA27249@lst.de> <20190814132746.GE13756@mellanox.com> <20190815180325.GA4920@redhat.com> <20190815194339.GC9253@redhat.com> <20190815203306.GB25517@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190815203306.GB25517@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 04:33:06PM -0400, Jerome Glisse wrote: > So nor HMM nor driver should dereference the struct page (i do not > think any iommu driver would either), Both current hmm drivers convert the hmm pfn back to a page and eventually call dma_map_page on it. As do the ODP patches from you.