Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp546428ybl; Thu, 15 Aug 2019 23:39:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhDsVgzL0fusUACicgxbldfLqGbAFyAa75SkPZopoQYS+bGs+ESJuSLBn6YqRQ2ByV3tJp X-Received: by 2002:a17:902:2f24:: with SMTP id s33mr7457714plb.314.1565937572301; Thu, 15 Aug 2019 23:39:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565937572; cv=none; d=google.com; s=arc-20160816; b=FF0XMbQ3+YoqX9l+hexUY5AYS6HoVyP/4/CnuZ+6i7RK1YDkXKsrR2aPkz3tJEWBof /uEMs90HtTjGpa1DMLv86mDsI4eBKApjBFE4zoqgfEC+R5Id43fPNazNEajtZoBXUScS hWY8pni15rg/JDZJawqOFFoRhLtvfzVsCQLiGWntJ9HLwkqyIBdsBc7QOx9ixl7tkS1W Y+Hcp9LgV4eBxYzitmV4LHvSydxjgrLmZF/fRIvANBsFOUT3KbFu7gzIf/eD4C2j2KOE MgM3c2bYI67Gt1VhlfArs8s6+ww5mxrME9eBSpHJ/PPyYIIcEveK3v7RqWHFfY2vFhK0 MSbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5Vqiu9wtaNx8kVRzHPBxlLz2F2d6oTzKG7AVaoCM5PU=; b=Ek2SesVHlgVEJaM1VAkLAbL1oSywBTY2V/CTeenuCfwcz80F9nrLkwibKE2dkGn99s Uh2mYcuvG1HT//+KeRZiMuZdWnHzbugBIR4FHzSEsPnhbv1d/p9l1ChMX3LExa4rDJws HSgpns5x4G11vagonep1JnKUKDu8qRBtO2TC7PyVflnyflH9jKePT6H0ZuTpdpbg4DIo knwnmj2iIOeeWxWANgbhQDdrxM4gc+EP1qsopKspTdbeyYrbse3khejhPMa+Z0nRSvoD tZcAg7oEeonVSEtd9YM5gmP7Ta1i148UHQ+AkHyXwLABBtMn6kUKkLsyWDTnbM9qQPxQ 68dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=V1pG1doA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si3231587pgq.538.2019.08.15.23.39.15; Thu, 15 Aug 2019 23:39:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=V1pG1doA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfHPGil (ORCPT + 99 others); Fri, 16 Aug 2019 02:38:41 -0400 Received: from mail.skyhub.de ([5.9.137.197]:52106 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbfHPGik (ORCPT ); Fri, 16 Aug 2019 02:38:40 -0400 Received: from zn.tnic (p200300EC2F0A920041519BC41B2ACCA3.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9200:4151:9bc4:1b2a:cca3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8C8E51EC0A91; Fri, 16 Aug 2019 08:38:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565937519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=5Vqiu9wtaNx8kVRzHPBxlLz2F2d6oTzKG7AVaoCM5PU=; b=V1pG1doAqPi4XoqA2IBe8N40J5t74wL8WVTo6puCBmWddUU3k/Khf7QOat3LZ6FoCArSVX RUEzU4Ng1uH9iV7KWOckv85k2fnd8FJc5j+6mp5X1Va7mnWKkO3aa/DvZ6ylTFfWODEDq/ J4RhIRXf3QR4LrTQAkdTqeyVY2LF2gU= Date: Fri, 16 Aug 2019 08:39:25 +0200 From: Borislav Petkov To: Zhao Yakui Cc: x86@kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [RFC PATCH 00/15] acrn: add the ACRN driver module Message-ID: <20190816063925.GB18980@zn.tnic> References: <1565922356-4488-1-git-send-email-yakui.zhao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1565922356-4488-1-git-send-email-yakui.zhao@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 16, 2019 at 10:25:41AM +0800, Zhao Yakui wrote: > The first three patches are the changes under x86/acrn, which adds the > required APIs for the driver and reports the X2APIC caps. > The remaining patches add the ACRN driver module, which accepts the ioctl > from user-space and then communicate with the low-level ACRN hypervisor > by using hypercall. I have a problem with that: you're adding interfaces to arch/x86/ and its users go into staging. Why? Why not directly put the driver where it belongs, clean it up properly and submit it like everything else is submitted? I don't want to have stuff in arch/x86/ which is used solely by code in staging and the latter is lingering there indefinitely because no one is cleaning it up... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.