Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp634574ybl; Fri, 16 Aug 2019 01:21:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyP4m7ilgEpg2yRVR1o0fL71vzFBVslli14RWmORlIP20NwqMd0Y5R+POIA/wVf2ZiiYRZn X-Received: by 2002:aa7:9638:: with SMTP id r24mr9230700pfg.68.1565943693282; Fri, 16 Aug 2019 01:21:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565943693; cv=none; d=google.com; s=arc-20160816; b=v87oeS0mE343HYKwuJdesA301Tkr7MoVCusD3mF2D/pAbxJFX1uRnY1O8bIEMNVREN FfS4mSOLOWLhwL/0+YHCmSBO1ngmuI+JrbWF68nl35I49pvq7WGU1JHAaOud4ZTGkZ+B 3zmnoPuYLrFG0rmdm99mtUtL45T0OQmpGJipFwhi89gOml14vSYIW6WcvCwgLyYOO+/T bLLcnJ6XcsZkuBPCWkf23nlSCBXSLFFE7/nB9uxmWcGf0/Qw+7VprFXzQq9Znyp7YBMc Ta+6S55LTQpoc81+mqH/HOSvKmjAfL0BnE9RYg7c3egrF9tMNpO2YiljRIMhdn4iZuD3 0VLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=QjA/egCYgtmlSRb6LVHxUqzmh8qLH56AQuj5prkE4BI=; b=Hc5zgAoGVaC8cgg4O28TDU+5vLEVEO5RtgGPCyb9+WWt2wPWf0sbboaR59fUeSOxg2 ko503qpXxD4oB1OrTcsgQehUOErxxn0bajw9l1Vgcy7j0N+KIWnyZP8XK5+HwONlDxI4 2KpXTk2BWnF1JqMiRCtZUF7fKmzR0EeohTNmE3YOdtEQE2pLpu6hlipMA759+flxiWLf OJx6rsqCcbLZlhFTEmxLG0nnp4hRqtuqyEKJv9fnxEKVAPDG5gM0MIYZvOQWhVBd5R1k RXIaz5AuNy+oMTpW6mQHS97sOmEVnvngFBeGnjFEIcaOyitqiDk4XIz0N0ee3VLGXgyg Ycpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si2329928pfi.248.2019.08.16.01.21.15; Fri, 16 Aug 2019 01:21:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727024AbfHPITy (ORCPT + 99 others); Fri, 16 Aug 2019 04:19:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:40836 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726575AbfHPITy (ORCPT ); Fri, 16 Aug 2019 04:19:54 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E024EB04C; Fri, 16 Aug 2019 08:19:52 +0000 (UTC) Date: Fri, 16 Aug 2019 10:19:46 +0200 (CEST) From: Miroslav Benes To: Masahiro Yamada cc: Joe Lawrence , Linux Kernel Mailing List , live-patching@vger.kernel.org, Linux Kbuild mailing list Subject: Re: [PATCH v4 06/10] modpost: Add modinfo flag to livepatch modules In-Reply-To: Message-ID: References: <20190509143859.9050-1-joe.lawrence@redhat.com> <20190509143859.9050-7-joe.lawrence@redhat.com> <20190812155626.GA19845@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > I cleaned up the build system, and pushed it based on my > kbuild tree. > > Please see: > > git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git > klp-cleanup This indeed looks much simpler and cleaner (as far as I can judge with my limited kbuild knowledge). We just need to remove MODULE_INFO(livepatch, "Y") from lib/livepatch/test_klp_convert_mod_a.c to make it compile and work (test_klp_convert_mod_a is not a livepatch module, it is just a dummy module which is then livepatched by lib/livepatch/test_klp_convert1.c). Thanks a lot! Miroslav