Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 16 Aug 2019 10:27:53 +0200
From:   Petr Mladek <pmladek@suse.com>
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 4/8] printk: Replace strncmp with str_has_prefix
Message-ID: <20190816082753.wvaj7hzn4zu3jgjd@pathway.suse.cz>
References: <20190809071034.17279-1-hslester96@gmail.com>
 <20190814104941.qt66ozcau5fdswcs@pathway.suse.cz>
 <20190815075033.GA26479@tigerII.localdomain>
 <20190815135221.qcgerido7aahmpgn@pathway.suse.cz>
 <CANhBUQ3Gco8kR7xiMknFv3ryyfnfeiJO1R-rHzNWBux8b8=LSw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANhBUQ3Gco8kR7xiMknFv3ryyfnfeiJO1R-rHzNWBux8b8=LSw@mail.gmail.com>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu 2019-08-15 23:33:01, Chuhong Yuan wrote:
> On Thu, Aug 15, 2019 at 9:52 PM Petr Mladek <pmladek@suse.com> wrote:
> >
> > On Thu 2019-08-15 16:50:33, Sergey Senozhatsky wrote:
> > > On (08/14/19 12:49), Petr Mladek wrote:
> > > > On Fri 2019-08-09 15:10:34, Chuhong Yuan wrote:
> > > > > strncmp(str, const, len) is error-prone because len
> > > > > is easy to have typo.
> > > > > The example is the hard-coded len has counting error
> > > > > or sizeof(const) forgets - 1.
> > > > > So we prefer using newly introduced str_has_prefix()
> > > > > to substitute such strncmp to make code better.
> > > > >
> > > > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> > > >
> > > > Reviewed-by: Petr Mladek <pmladek@suse.com>
> > >
> > > Reviewed-by:  Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> >
> > Chuong Yuan, should I take this patch via printk.git? Or will
> > the entire series go via some other tree, please?
> >
> 
> I think that it goes via printk.git is okay, thanks!

The patch is commited into printk.git, branch for-5.4.

Best Regards,
Petr