Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp718323ybl; Fri, 16 Aug 2019 02:56:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6ClXAJV9w0d0bbcvqd/JmBiToWKJBMzOEFw4aL0ZkzpSGWXw0o8kxIJKIiZ7Nd3FT/Myw X-Received: by 2002:a65:690f:: with SMTP id s15mr6827652pgq.432.1565949393987; Fri, 16 Aug 2019 02:56:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565949393; cv=none; d=google.com; s=arc-20160816; b=M3Omr/UYMdoQR8Ngh+AoZixjHm9Jc7EMXEcOuNjOuQgwFI8YEU3bFucMO2R9UrKreq jjwG9GDqantbx4lrxBS44kA+2uF2Co8zgpvWDBWgiJwA2BbUXwCVDze08fSzEF+Mpb1W +9ANFApldO9zdPC/HPOVDBXTJXo8ss4WNN3p5VoktgxcO1u1iTVCUjaZyBKbD8NLcPMh xNZ43JcZozUMBFquvI1t6oZbk745NLEM2yIiH1USnopk7Sxl50CjblFFrDCcUBafteBL JkHrejRLWdwS+tJFDP5+MJCd2gY7c+mWDc/H+4cks508F/rNcV3oJq7lnI168wEWxqkT CPyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XweYhjF+rXykrgPaapT+0IRgJwtUWbywHZya/wVe2z8=; b=F01+TZsqRViJApQf6t/X5kFW7pQEs/ipLq1yHz/mdvCx7t84gytoT678fnWvzJDPx+ saeb0LXi3YP9dQVFm/IUdkNjXoaDscoQfvRyL6KxgQ9UOLI5yIDAL9DKf6k2TSEvYZO4 Xkn9h2paB11WGWHMG/n4HptiXIZwVmmnVaND2qnE0jPCBee5R2e50Lh3By/FxLksvlRt +5+ZLfKK/c1Ae4Fx4Bq8zABNigHvWsVceJXUxavdIUnD0cgvEekwQelwz7+nfzgLoHKI end92pdmvPLZjBilTwu5nosK3lUPBff9o5oPl/v0DsBKc37YT05MBem9wxJma4/o5W64 +h7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="HU2hDoO/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si3767211plz.101.2019.08.16.02.56.16; Fri, 16 Aug 2019 02:56:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="HU2hDoO/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfHPJzP (ORCPT + 99 others); Fri, 16 Aug 2019 05:55:15 -0400 Received: from mail.skyhub.de ([5.9.137.197]:54000 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726842AbfHPJzP (ORCPT ); Fri, 16 Aug 2019 05:55:15 -0400 Received: from zn.tnic (p200300EC2F0A920014AE47D987991812.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9200:14ae:47d9:8799:1812]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 023921EC074B; Fri, 16 Aug 2019 11:55:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1565949314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XweYhjF+rXykrgPaapT+0IRgJwtUWbywHZya/wVe2z8=; b=HU2hDoO/gvHu/qH+BDbnS23Qq8G1b2bQEtB5/fuw6HXflolKiNqJgFmoiadTD0h+9iv076 kGjxSWWVNVVRAlfyeLxqSAbo7nlijvNXvyAFFUgtFye496BCbqhoDE5o34FP7k1Z1UBZee QGgBkGSLywIPsqz0QGWWv0mrlCnYkT4= Date: Fri, 16 Aug 2019 11:55:59 +0200 From: Borislav Petkov To: Robert Richter Cc: James Morse , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 13/24] EDAC, ghes: Add support for legacy API counters Message-ID: <20190816095559.GL18980@zn.tnic> References: <20190624150758.6695-1-rrichter@marvell.com> <20190624150758.6695-14-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190624150758.6695-14-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 03:09:22PM +0000, Robert Richter wrote: > The ghes driver is not able yet to count legacy API counters in sysfs, > e.g.: > > /sys/devices/system/edac/mc/mc0/csrow2/ce_count > /sys/devices/system/edac/mc/mc0/csrow2/ch0_ce_count > /sys/devices/system/edac/mc/mc0/csrow2/ch1_ce_count > > Make counting csrows/channels generic so that the ghes driver can use > it too. What for? ghes_edac enumerates the DIMMs from SMBIOS - it doesn't need chip selects and ranks. Those are used when you can't count the DIMMs properly... -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.