Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp963663ybl; Fri, 16 Aug 2019 06:53:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBA734lhBmgi2e/bfTBOpKSsd4jPuHixwvyEBlxBZQog9tv2SBPREyGamseX1LRSEDK6pZ X-Received: by 2002:a65:60cd:: with SMTP id r13mr8099966pgv.315.1565963580926; Fri, 16 Aug 2019 06:53:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565963580; cv=none; d=google.com; s=arc-20160816; b=FutGb0vo8Z0/LZR0+BXBLzF+OxOJ4YaYM9dNjUMYnfi2RkY8veg6LJhjrXjPrbbbO3 n5eVLxK50sDTDK9XeJkE3OmUXv7OvqliwzHrymX46+aF9+xQ9SoHXhDDWAY8Bxlq/ANh yOt0MHAYAytbYWzv1k4lEnZ/dDy5UR/hQZf5aH0vlc4SzfnkRL2/fvNfpX9PU1yyJ9wy GryTGOK+kHBmdrMFQK8Wv5KUENBpI+0WcYVV3wj/Ta4kf/5+AbJzkO6Co/Vjdz6MEypI zOzoAKYAvmJcdOEW0niFhZAOmNfXN10Qr8agJzh3os2Z+pkMpDC6ZPyP5+6dMgYfUVUn 82Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nPmZTpbJMpVctnASYyGv1FAcE7TZhdmLXQakXmIUe7Y=; b=KAt9zxCHqw3D3/hP4xwtkhPR/2ajJhGR0cSN1JyZo8TTg+4XmRfqIZDFTst0V7cJ3/ 7csKxJHt4WnVQnKL8dG8tW1krev4GXQOvL5RSZZqzPON+Eo4uSYaRTqky2iJjbqLvN1b bvnB/V37gsrDq9lNzjoWqDYeRjD+G0JOzsRF5Oxq1pLy7Sbap0Zzo4R+tB1KZDqSsQmh TIw/Zn8cAfyrs6s29c7Lt6EsmyE1lT2Ay5wHjkzqkzhg0DIoo9XIgYWjALhrD5rVYdgc qtXw6g8okX6mf5Ox5UCK+p0uNQg6fIgiuCUWVx33/oaHVnqmLd0lhRt3hdL0zyh5Z4gG GHbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OkVZeB1e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si3879413pgu.98.2019.08.16.06.52.44; Fri, 16 Aug 2019 06:53:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OkVZeB1e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727286AbfHPNwL (ORCPT + 99 others); Fri, 16 Aug 2019 09:52:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:37570 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726032AbfHPNwK (ORCPT ); Fri, 16 Aug 2019 09:52:10 -0400 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94A0C206C1; Fri, 16 Aug 2019 13:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565963529; bh=gS9VqZmvmfGbR0N8qErfyrR/eTspxZrCQqpp7PM80DY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OkVZeB1e9Fv4R3Rgq1JACVcXgNAyC+GyBvIMgTm4sPkvE1Kk9EY2kUvzHVKXsUCuV cG9UTO6G9VKjRJll291q4KhgcbJKAMMLERp1QhdcRF7p2tC9kC9KFZxVjI3VouBxXu oQ6SlUDhlVxqBkX7w17JFYPC53FGCOcJlbAXSZMg= Date: Fri, 16 Aug 2019 15:52:06 +0200 From: Maxime Ripard To: Corentin Labbe Cc: mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] ARM64: dts: allwinner: Add devicetree for pine H64 modelA evaluation board Message-ID: <20190816135206.pnf3iperzyhcbg4h@flea> References: <20190808084253.10573-1-clabbe.montjoie@gmail.com> <20190812094000.ebdmhyxx7xzbevef@flea> <20190814131741.GB24324@Red> <20190814133322.dawzv3ityakxtqs4@flea> <20190816093513.GA25042@Red> <20190816113650.hstbi5ntstx3wh4a@flea> <20190816115750.GA24545@Red> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fm6eqvrpk6hsimfz" Content-Disposition: inline In-Reply-To: <20190816115750.GA24545@Red> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fm6eqvrpk6hsimfz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 16, 2019 at 01:57:50PM +0200, Corentin Labbe wrote: > On Fri, Aug 16, 2019 at 01:36:50PM +0200, Maxime Ripard wrote: > > On Fri, Aug 16, 2019 at 11:35:13AM +0200, Corentin Labbe wrote: > > > On Wed, Aug 14, 2019 at 03:33:22PM +0200, Maxime Ripard wrote: > > > > On Wed, Aug 14, 2019 at 03:17:41PM +0200, Corentin Labbe wrote: > > > > > On Mon, Aug 12, 2019 at 11:40:00AM +0200, Maxime Ripard wrote: > > > > > > On Thu, Aug 08, 2019 at 10:42:53AM +0200, Corentin Labbe wrote: > > > > > > > This patch adds the evaluation variant of the model A of the PineH64. > > > > > > > The model A has the same size of the pine64 and has a PCIE slot. > > > > > > > > > > > > > > The only devicetree difference with current pineH64, is the PHY > > > > > > > regulator. > > > > > > > > > > > > > > Signed-off-by: Corentin Labbe > > > > > > > --- > > > > > > > arch/arm64/boot/dts/allwinner/Makefile | 1 + > > > > > > > .../sun50i-h6-pine-h64-modelA-eval.dts | 26 +++++++++++++++++++ > > > > > > > 2 files changed, 27 insertions(+) > > > > > > > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > > index f6db0611cb85..9a02166cbf72 100644 > > > > > > > --- a/arch/arm64/boot/dts/allwinner/Makefile > > > > > > > +++ b/arch/arm64/boot/dts/allwinner/Makefile > > > > > > > @@ -25,3 +25,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-3.dtb > > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-lite2.dtb > > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-orangepi-one-plus.dtb > > > > > > > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64.dtb > > > > > > > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h6-pine-h64-modelA-eval.dtb > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > > new file mode 100644 > > > > > > > index 000000000000..d8ff02747efe > > > > > > > --- /dev/null > > > > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64-modelA-eval.dts > > > > > > > @@ -0,0 +1,26 @@ > > > > > > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > > > > > > +/* > > > > > > > + * Copyright (C) 2019 Corentin Labbe > > > > > > > + */ > > > > > > > + > > > > > > > +#include "sun50i-h6-pine-h64.dts" > > > > > > > + > > > > > > > +/ { > > > > > > > + model = "Pine H64 model A evaluation board"; > > > > > > > + compatible = "pine64,pine-h64-modelA-eval", "allwinner,sun50i-h6"; > > > > > > > + > > > > > > > + reg_gmac_3v3: gmac-3v3 { > > > > > > > + compatible = "regulator-fixed"; > > > > > > > + regulator-name = "vcc-gmac-3v3"; > > > > > > > + regulator-min-microvolt = <3300000>; > > > > > > > + regulator-max-microvolt = <3300000>; > > > > > > > + startup-delay-us = <100000>; > > > > > > > + gpio = <&pio 2 16 GPIO_ACTIVE_HIGH>; > > > > > > > + enable-active-high; > > > > > > > + }; > > > > > > > + > > > > > > > +}; > > > > > > > + > > > > > > > +&emac { > > > > > > > + phy-supply = <®_gmac_3v3>; > > > > > > > +}; > > > > > > > > > > > > I might be missing some context here, but I'm pretty sure that the > > > > > > initial intent of the pine h64 DTS was to support the model A all > > > > > > along. > > > > > > > > > > > > > > > > The regulator changed between modelA and B. > > > > > See this old patchset (supporting modelA) https://patchwork.kernel.org/patch/10539149/ for example. > > > > > > > > I'm not sure what your point is, but mine is that everything about the > > > > model A should be in sun50i-h6-pine-h64.dts. > > > > > > > > > > model A and B are different enough for distinct dtb, (see sub-thread > > > on HDMI difference for an other difference than PHY regulator) > > > > I don't mind having separate DTBs for model A and model B. > > > > > And clearly, the current dtb is for model B. > > > > That DTS was added almost a year before the model B was announced, and > > no commit to that file mention the model B, so it's definitely not > > clear. > > Normal it was added for model A (without any ethernet/HDMI support, > so nothing distinct from model B), and the modelB ethernet/HDMI > support cames after. Changing the board a DT is meant to halfway through the development is definitely not ok. > > > So do you mean that we need to create a new dtb for model B ? (and > > > hack the current back to model A ?) > > > > I'd prefer not to hack anything, but yes > > > > Since model A is not public (only evaluations boards exists), the > probability of a production model A is low and the current dtb is > perfect for model B , could you reconsider this ? I mean, you could buy it, so it's definitely public. Model A also had HDMI, and it doesn't look like there's anything particularly specific with that board. On the Ethernet side, the only thing that changes is the regulator / GPIO being used to enable the PHY? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --fm6eqvrpk6hsimfz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXVa1BgAKCRDj7w1vZxhR xXZnAP9aZUwT4DWi8c6jqu7/WRRfPPuh9bZvqdp/f2vLIFEr3wEA8rkg7Yr0qaGI ijHkFUuhz0wbkTqVdhD0FhUCCStlqww= =haXH -----END PGP SIGNATURE----- --fm6eqvrpk6hsimfz--