Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roy Pledge <roy.pledge@nxp.com>
To:     Leo Li <leoyang.li@nxp.com>, Ioana Ciornei <ioana.ciornei@nxp.com>
CC:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS
Thread-Topic: [PATCH 3/3] soc: fsl: FSL_MC_DPIO selects directly FSL_GUTS
Thread-Index: AQHVMa+L6jLIgK/rPECnX4ICjDsk6Q==
Date:   Fri, 16 Aug 2019 14:56:41 +0000
Message-ID: <VE1PR04MB64636237CB3B1B2A93E0507786AF0@VE1PR04MB6463.eurprd04.prod.outlook.com>
References: <1562165800-30721-1-git-send-email-ioana.ciornei@nxp.com>
 <1562165800-30721-4-git-send-email-ioana.ciornei@nxp.com>
 <CADRPPNT9LGdMWuBcBnvWXhD8Q-qbTNOzbYp1dRrt0NXb2DBgDw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: df5c9a7d-ea99-4ac6-e9c0-08d72259f2bf
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2019 14:56:41.4242
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GXdrbc/1eludVsrG4vs1BmmvA4ORnTE1M5T9bmZ4/YPU9a3zkoDqMyLn85XbF5NwZtUR41XfDvfSbSZJkBdUsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6589
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/15/2019 7:09 PM, Li Yang wrote:=0A=
> On Wed, Jul 3, 2019 at 9:58 AM Ioana Ciornei <ioana.ciornei@nxp.com> wrot=
e:=0A=
>> Make FSL_MC_DPIO select directly FSL_GUTS. Without this change we could=
=0A=
>> be in a situation where both FSL_MC_DPIO and SOC_BUS are enabled but=0A=
>> FSL_GUTS is not.=0A=
>>=0A=
>> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>=0A=
>> ---=0A=
>>  drivers/soc/fsl/Kconfig | 2 +-=0A=
>>  1 file changed, 1 insertion(+), 1 deletion(-)=0A=
>>=0A=
>> diff --git a/drivers/soc/fsl/Kconfig b/drivers/soc/fsl/Kconfig=0A=
>> index b6804c04e96f..7e62c1d0aee7 100644=0A=
>> --- a/drivers/soc/fsl/Kconfig=0A=
>> +++ b/drivers/soc/fsl/Kconfig=0A=
>> @@ -22,7 +22,7 @@ config FSL_GUTS=0A=
>>  config FSL_MC_DPIO=0A=
>>          tristate "QorIQ DPAA2 DPIO driver"=0A=
>>          depends on FSL_MC_BUS=0A=
>> -        select SOC_BUS=0A=
>> +        select FSL_GUTS=0A=
> NACK.  Although DPIO only exists on SoCs with the GUTS block for now.=0A=
> There is no direct dependency between the two IPs.  I don't think we=0A=
There isn't a hardware dependency but the DPIO driver does call=0A=
soc_device_match().  If FSL_GUTS isn't present we can't distinguish=0A=
which SoC is being used and the driver isn't able to setup the correct=0A=
stashing destinations.  Is there another mechanism we should be using to=0A=
get this information?=0A=
> should add this dependency to make FSL_GUTS not configurable.  Here is=0A=
> some explaination from kernel documentation:=0A=
>=0A=
>         select should be used with care. select will force=0A=
>         a symbol to a value without visiting the dependencies.=0A=
>         By abusing select you are able to select a symbol FOO even=0A=
>         if FOO depends on BAR that is not set.=0A=
>         In general use select only for non-visible symbols=0A=
>         (no prompts anywhere) and for symbols with no dependencies.=0A=
>         That will limit the usefulness but on the other hand avoid=0A=
>         the illegal configurations all over.=0A=
>=0A=
> We probably shouldn't let it select SOC_BUS either from the beginning,=0A=
> as the basic feature of DPIO should still work without defining=0A=
> SOC_BUS.=0A=
>=0A=
> Regards,=0A=
> Leo=0A=
>=0A=
>>          help=0A=
>>           Driver for the DPAA2 DPIO object.  A DPIO provides queue and=
=0A=
>>           buffer management facilities for software to interact with=0A=
>> --=0A=
>> 1.9.1=0A=
>>=0A=
=0A=