Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1095270ybl; Fri, 16 Aug 2019 08:49:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEy8/4as9dFXjgUCROUqe/MqhuJzsVO475zSsnDP6GikRsHA5pn9CTJvSpf6LlFY04h5UZ X-Received: by 2002:a63:c009:: with SMTP id h9mr8357020pgg.166.1565970563254; Fri, 16 Aug 2019 08:49:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565970563; cv=none; d=google.com; s=arc-20160816; b=hDWIBhJOAqffDp5+AkDWXn9pe5FHYk4oMMOautdyJuZBvCj+ILlGjwzkHMXLtRVFEG gW/yqNw4ICS7FvxTvTxb1u01fBHHPuYz7UUh4kPKuWob60CWJG9WxxU2CdkkyMPKnhlE PkUPiEO5Om/DkgGhIPEtrgCs9DHXM8IzVBa7K0TKHrqn5pncBloo0uCsSAp1pqu6rBL8 Za76FtUH4yOAqH4UxiHuhm8VlQuhrFpG3VN8UMFckwYSpwNBtFPByvo/Vh4D5Aoi8yVV yGBfuoAYG2bAa2/UClU4JSEir0AFUWE9n+13ARqBUu4XbsE+3soSVRotXFzm7nRJSGTe q1PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=/rVwYCxqOr6nRrp3LvLIcdjfULOr8AyFlrBXkong6Uc=; b=m32SYVhK9hErjBx5xpzHdf4OZCwrog8j7x9HNjS1MmIyhtGhIYk3ViOCkwsU9skCeN 8ovh0PCu85kaDduxGPFHSjANMBOKt6AXAY6N77r9QO8ilsSd/tOUl9u2GgipPqWAVANd zMShjOqM4PLJZc8CW0NMGnLbfzBcI8g7008gPMe5XT78vqjHd66uD3sVyKaaW5xqgXVz 6C1b5Bp2fGBH6IYeybDhv07Goqf4JHnnMVpnZoqeB7nb0RmYu3FQTAe24a75UoZr83ey ObYanodwEbvQlQcF8BsQVu1W2dxFhnkKUcGu9XdNqMXrSdE+B0CZXk9llMqyLY1qbS7N F4uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=fXFbSidY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si4233922plp.325.2019.08.16.08.49.07; Fri, 16 Aug 2019 08:49:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20150623.gappssmtp.com header.s=20150623 header.b=fXFbSidY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727441AbfHPPse (ORCPT + 99 others); Fri, 16 Aug 2019 11:48:34 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:46016 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbfHPPse (ORCPT ); Fri, 16 Aug 2019 11:48:34 -0400 Received: by mail-io1-f66.google.com with SMTP id t3so7073897ioj.12 for ; Fri, 16 Aug 2019 08:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/rVwYCxqOr6nRrp3LvLIcdjfULOr8AyFlrBXkong6Uc=; b=fXFbSidYUWUDlCh4xn1T/uZ5jLY9vlVpMj5VEkuiqHXz+qMOCKxapObfLA3nEgPC7R vbKAhlMWcM4J+Eji7i5R6bwo4AeGu9fnIYkpCAzv8oSULwGLPD3LqKmsHrjooKwmPZlg CPFFPDdRWkrJe6ua3OTZ34Gz1O0O8vSQoh64ZKeWJzsOfIgCrQ5x1SjgRLt2BFPW6eno miP6aVQIgyGJOM2QklUITTu5iuxab7KfiAgaTBKrd+U5OvNlNtDzA+RPScqKLXahRxhU onl3wAUB2zIim3HOXqpJCz4CfO6R/P8hrD8OguzyI92HPBSdWK0xd3s2kHKgHsp4TiYl +oyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/rVwYCxqOr6nRrp3LvLIcdjfULOr8AyFlrBXkong6Uc=; b=V473gJHokorx5V0o8nz4VFvIEoywfAFfSPhmmN3ynjtwhrmCNaV2J6/x5dm41N9Woq nKBcZAVSqkKn6vFjewnysDOTjZQjVV22UqfDglW5RP64iJVndghX9mgOxaPLgkkmnKOO G6CQI+Hr+1wfx/Cnwr4arzbvDF36dOZNkewSRLw+2lBozPUI+yj0OIHMOwUH5Vq+5iND 7n10Y3RnVeNmnJnTz4kBaYJL098Hyg+zEXqzBRRL2pj70P/TEwLmYtpL721YPrX24/C6 b7COvOo9JtggbXq6SYGE9N+1JaZxlwr9WQsM//VsBfVHpRylWigqY37ZZpguwIcS/SCN eXJw== X-Gm-Message-State: APjAAAWifUWYebvjGYvqao11Y7PuEu5E+0vINod9FLu0POufF2NF93nq 1KuzCVVDqTOJL7fFp13l/YJkZQg2VbaVps+optLxVA== X-Received: by 2002:a5d:8457:: with SMTP id w23mr472306ior.189.1565970513627; Fri, 16 Aug 2019 08:48:33 -0700 (PDT) MIME-Version: 1.0 References: <20190724082508.27617-1-brgl@bgdev.pl> In-Reply-To: From: Bartosz Golaszewski Date: Fri, 16 Aug 2019 17:48:22 +0200 Message-ID: Subject: Re: [PATCH v3 0/7] backlight: gpio: simplify the driver To: Yoshinori Sato , Rich Felker Cc: linux-sh@vger.kernel.org, Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Bartosz Golaszewski , Lee Jones , Bartlomiej Zolnierkiewicz , Jingoo Han , Andy Shevchenko , Daniel Thompson , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org czw., 8 sie 2019 o 10:17 Bartosz Golaszewski napisa=C5=82(a= ): > > =C5=9Br., 24 lip 2019 o 10:25 Bartosz Golaszewski napisa= =C5=82(a): > > > > From: Bartosz Golaszewski > > > > While working on my other series related to gpio-backlight[1] I noticed > > that we could simplify the driver if we made the only user of platform > > data use GPIO lookups and device properties. This series tries to do > > that. > > > > The first patch adds all necessary data structures to ecovec24. Patch > > 2/7 unifies much of the code for both pdata and non-pdata cases. Patche= s > > 3-4/7 remove unused platform data fields. Last three patches contain > > additional improvements for the GPIO backlight driver while we're alrea= dy > > modifying it. > > > > I don't have access to this HW but hopefully this works. Only compile > > tested. > > > > [1] https://lkml.org/lkml/2019/6/25/900 > > > > v1 -> v2: > > - rebased on top of v5.3-rc1 and adjusted to the recent changes from An= dy > > - added additional two patches with minor improvements > > > > v2 -> v3: > > - in patch 7/7: used initializers to set values for pdata and dev local= vars > > > > Bartosz Golaszewski (7): > > sh: ecovec24: add additional properties to the backlight device > > backlight: gpio: simplify the platform data handling > > sh: ecovec24: don't set unused fields in platform data > > backlight: gpio: remove unused fields from platform data > > backlight: gpio: remove dev from struct gpio_backlight > > backlight: gpio: remove def_value from struct gpio_backlight > > backlight: gpio: use a helper variable for &pdev->dev > > > > arch/sh/boards/mach-ecovec24/setup.c | 33 ++++++-- > > drivers/video/backlight/gpio_backlight.c | 82 +++++--------------- > > include/linux/platform_data/gpio_backlight.h | 3 - > > 3 files changed, 44 insertions(+), 74 deletions(-) > > > > -- > > 2.21.0 > > > > Hi Rich, Yoshinori, > > can you ack the sh patches in this series? > > Bart Ping.