Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1196401ybl; Fri, 16 Aug 2019 10:27:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJTCGzFovC1dtslk/BOtSgI0udX9odfOG2VUgAvc2yGwvDJ1BLjQJrXXKu2MsYHMI0mSVj X-Received: by 2002:a17:90a:be07:: with SMTP id a7mr8268979pjs.88.1565976463781; Fri, 16 Aug 2019 10:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565976463; cv=none; d=google.com; s=arc-20160816; b=hbkYvcTA9jao6CEUTDF/8F3PMQyR+fk4eOX6XHzmHzwD/XCLnj5OaKP8wp07bZ0iMU b9yrMT/MDcEmMq4H0CCp/6U06vaX+vDXGMz9DIOG0kazd5aIBi9Ub34SycW/5N/4B1bC E84TqH55VVDff6AAxFGDs/QOmfSLV3nCPViR9v+1udmv8MQo0fyCsJXtmR+2LzSW8V1L TA0cs8ame7aRz6QHz1BQIAkqCDvLG5kzE752ho7bei8fSzJoMLrEmxQTZuJHUZ7JX66l 7RLL76vK2FTAme/f9OoQaK9XnpLYDxrU7G0HFjKjErElSaUPo4bqxfZvkKRRnu+OZmb8 hfRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:to:cc:from :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=l2UhekZfp46Gm4ghaGYnz4/LUNxAABqLtkbqZkEPCNg=; b=pZGcwHYdEXVteEabA/YI3OOBjZ5AalZx4kZhLmgmdxD/VgnCk6VS1QXgqs9Z05P1aT Qd66w1UN7gmJC85zBANRP/i75U8lK6oN6ooHtP6x02aCzdvWCZL96c4dMmMRVi39PVO/ w2rftaLp2t34omvx6hS5S3ysckEdLea/E3PR100WY5mgTJtm5xCGz2+9GkXvgwVirgVW /fHPLucznl+eECAaeIYj+tVGLE9ialvMqTHhYjAZEjaisBgM12iWlQ6utBlvSV0/1hpg ag6mM6Hs3UrKgvTgk0kXZjpg5xK+kLmQFGdXTqSTI795Us6P76mF/LWm847SdDW+C63Y /W+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gD5G1dqI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12si3097373pfo.30.2019.08.16.10.27.27; Fri, 16 Aug 2019 10:27:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gD5G1dqI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbfHPRZH (ORCPT + 99 others); Fri, 16 Aug 2019 13:25:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727529AbfHPRZH (ORCPT ); Fri, 16 Aug 2019 13:25:07 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 727322086C; Fri, 16 Aug 2019 17:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565976306; bh=l2UhekZfp46Gm4ghaGYnz4/LUNxAABqLtkbqZkEPCNg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=gD5G1dqI0AxFdz7yj5rpcx6Hb/aRlL6atXSEOPhTcs8zDfLbxz4oUOWe6oUctF30d 7oNlP/OFy7GGEHcR4Mf+JRceID6pn2el9azNIcWpvC44fY3tbCYbRGKW6dp7T4u0Jq ol9ZwtqsVTrMkDi66S+6oOdt5xkkBqDevVOyJXa4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190815041037.3470-1-sboyd@kernel.org> References: <20190815041037.3470-1-sboyd@kernel.org> Subject: Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai To: Michael Turquette , Stephen Boyd User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 10:25:05 -0700 Message-Id: <20190816172506.727322086C@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2019-08-14 21:10:37) > The implementation of clk_hw_get_name() relies on the clk_core > associated with the clk_hw pointer existing. If of_clk_hw_register() > fails, there isn't a clk_core created yet, so calling clk_hw_get_name() > here fails. Extract the name first so we can print it later. >=20 > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure") > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Signed-off-by: Stephen Boyd > --- Applied to clk-next