Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190816135523.73520-1-yuehaibing@huawei.com>
References: <20190816135523.73520-1-yuehaibing@huawei.com>
Subject: Re: [PATCH -next] clk: st: clkgen-pll: remove unused variable 'st_pll3200c32_407_a0'
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        YueHaibing <yuehaibing@huawei.com>
To:     YueHaibing <yuehaibing@huawei.com>, allison@lohutok.net,
        gregkh@linuxfoundation.org, mturquette@baylibre.com,
        Gabriel FERNANDEZ <gabriel.fernandez@st.com>
User-Agent: alot/0.8.1
Date:   Fri, 16 Aug 2019 10:36:12 -0700
Message-Id: <20190816173613.491082086C@mail.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting YueHaibing (2019-08-16 06:55:23)
> drivers/clk/st/clkgen-pll.c:64:37: warning:
>  st_pll3200c32_407_a0 defined but not used [-Wunused-const-variable=3D]
>=20
> It is never used, so can be removed.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Adding Gabriel, please ack/review.

>  drivers/clk/st/clkgen-pll.c | 13 -------------
>  1 file changed, 13 deletions(-)
>=20
> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
> index d8a688b..c3952f2 100644
> --- a/drivers/clk/st/clkgen-pll.c
> +++ b/drivers/clk/st/clkgen-pll.c
> @@ -61,19 +61,6 @@ static const struct clk_ops stm_pll3200c32_ops;
>  static const struct clk_ops stm_pll3200c32_a9_ops;
>  static const struct clk_ops stm_pll4600c28_ops;
> =20
> -static const struct clkgen_pll_data st_pll3200c32_407_a0 =3D {
> -       /* 407 A0 */
> -       .pdn_status     =3D CLKGEN_FIELD(0x2a0,   0x1,                   =
 8),
> -       .pdn_ctrl       =3D CLKGEN_FIELD(0x2a0,   0x1,                   =
 8),
> -       .locked_status  =3D CLKGEN_FIELD(0x2a0,   0x1,                   =
 24),
> -       .ndiv           =3D CLKGEN_FIELD(0x2a4,   C32_NDIV_MASK,         =
 16),
> -       .idf            =3D CLKGEN_FIELD(0x2a4,   C32_IDF_MASK,          =
 0x0),
> -       .num_odfs =3D 1,
> -       .odf            =3D { CLKGEN_FIELD(0x2b4, C32_ODF_MASK,          =
 0) },
> -       .odf_gate       =3D { CLKGEN_FIELD(0x2b4, 0x1,                   =
 6) },
> -       .ops            =3D &stm_pll3200c32_ops,
> -};
> -
>  static const struct clkgen_pll_data st_pll3200c32_cx_0 =3D {
>         /* 407 C0 PLL0 */
>         .pdn_status     =3D CLKGEN_FIELD(0x2a0,   0x1,                   =
 8),