Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1352795ybl; Fri, 16 Aug 2019 13:27:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDp/HtfntyX7Fo+LTpJrymNRHhmTSYH+59IlO3EIMwo5hQ9Gw+uogqSC3IklFGR0pfjnZ2 X-Received: by 2002:a63:9e56:: with SMTP id r22mr9274210pgo.221.1565987268267; Fri, 16 Aug 2019 13:27:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565987268; cv=none; d=google.com; s=arc-20160816; b=KkfANNmS8fNZY0H580JQrSMY7/hhIWjIb/ZVVpj18taRP2UgZVKuZU2twvbX8WQo2t Csk4RbQiv8Mag3Hc1l9Ida36iLtDkEEgVXCQ+N3f9Ajyva4O88jv++fah/3atgumDbz7 HfQpnmt0RrpoTkGXEl+VC9mFaldKeZH6k9Lj7whiiCgl4B3ITfZ1C5D6n0X18uVRxRwO iIaavx6r4HJ2Fa7iv/dGNlVjZVNpgw0hGrzRqTjMIoPbm0/tmXTHlSbj9pQ7gH4zCqiB HAI9WbGWVsia2GapjX/YxpOKVQVBh0i/bESfBH6ex7Hu1Z3b8jtCdIzmuQck1I0qBSJ7 vqlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:date:message-id :references:cc:to:subject:dkim-signature:from; bh=s9A+nkXWVA/jF2o9MhtP9GY66Zha2aaG5LtnYmm+FZk=; b=JXzW8wdlv4y0WZswptKEzck52Csz0TZxVqcMgvc/T1wwBuMwyNxHiMf1cpiO5E6kk1 Sj/t0MZIdKlc1iGols4f7KA1RVDAledEYix48G9rR/Uru2LAI9MlXhF+ayceW/sB8xLE 5EOk94mnql3oQuAbrf36QyD80h+cBpJexULU8WT23y7+fD+OeQlv+GCyimageRe15qZ6 HKAj5Bh6kbooypK13O+tDaby1Rh5kc4txEpQ1TUkInf6GXHIRlOTjNZwPiLyEMjA1wTV QKueaxHUccrc51Lvs4hFmXEkr2S6Ay3Wv34SgzN2T3So2+VjSefNyAs2p6HkMhiWh5qa FKgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@klausen.dk header.s=dkim header.b=HbFInzYx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=klausen.dk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si4968157pfb.122.2019.08.16.13.27.31; Fri, 16 Aug 2019 13:27:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@klausen.dk header.s=dkim header.b=HbFInzYx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=klausen.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727630AbfHPU0y (ORCPT + 99 others); Fri, 16 Aug 2019 16:26:54 -0400 Received: from mail.klausen.dk ([174.138.9.187]:52666 "EHLO mail.klausen.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727568AbfHPU0x (ORCPT ); Fri, 16 Aug 2019 16:26:53 -0400 X-Greylist: delayed 397 seconds by postgrey-1.27 at vger.kernel.org; Fri, 16 Aug 2019 16:26:52 EDT From: Kristian Klausen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klausen.dk; s=dkim; t=1565986812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s9A+nkXWVA/jF2o9MhtP9GY66Zha2aaG5LtnYmm+FZk=; b=HbFInzYxixr8DpRdSujExpk4Qnj2TL+nlNzxCd+8zdl9iLRZTJ07PriEb9iDB1TuBHj2MH rQaO2qSQpFOawtgs8823BoyI8+EMnRDTVWJJLzAbLbX8dgb1D+8dtEsC+DZ+AW6G8ctcud 3p/HPeXTs2blBx9pOcLnlMzF81XWVU0= Subject: Re: [PATCH v3 0/8] PM / ACPI: sleep: Additional changes related to suspend-to-idle To: "Rafael J. Wysocki" , Linux ACPI Cc: Linux PM , LKML , Zhang Rui , Rajneesh Bhardwaj , Andy Shevchenko , Mario Limonciello , Kai-Heng Feng References: <5997740.FPbUVk04hV@kreacher> Message-ID: <800186a2-e912-3498-f08b-47469bbe8b0d@klausen.dk> Date: Fri, 16 Aug 2019 22:20:10 +0200 MIME-Version: 1.0 In-Reply-To: <5997740.FPbUVk04hV@kreacher> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.08.2019 12.33, Rafael J. Wysocki wrote: > Hi All, > >>> On top of the "Simplify the suspend-to-idle control flow" patch series >>> posted previously: >>> >>> https://lore.kernel.org/lkml/71085220.z6FKkvYQPX@kreacher/ >>> >>> sanitize the suspend-to-idle flow even further. >>> >>> First off, decouple EC wakeup from the LPS0 _DSM processing (patch 1). >>> >>> Next, reorder the code to invoke LPS0 _DSM Functions 5 and 6 in the >>> specification-compliant order with respect to suspending and resuming >>> devices (patch 2). >>> >>> Finally, rearrange lps0_device_attach() (patch 3) and add a command line >>> switch to prevent the LPS0 _DSM from being used. >> The v2 is because I found a (minor) bug in patch 1, decided to use a module >> parameter instead of a kernel command line option in patch 4. Also, there >> are 4 new patches: >> >> Patch 5: Switch the EC over to polling during "noirq" suspend and back >> during "noirq" resume. >> >> Patch 6: Eliminate acpi_sleep_no_ec_events(). >> >> Patch 7: Consolidate some EC code depending on PM_SLEEP. >> >> Patch 8: Add EC GPE dispatching debug message. > The v3 is just a rearranged v2 so as to move the post sensitive patch (previous patch 2) > to the end of the series. [After applying the full series the code is the same as before.] > > For easier testing, the series (along with some previous patches depended on by it) > is available in the pm-s2idle-testing branch of the linux-pm.git tree at kernel.org: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=pm-s2idle-testing It was just testing this patch series(461fc1caed55), to see if it would fix my charging issue (https://bugzilla.kernel.org/show_bug.cgi?id=201307), which it didn't. I did however notice that my laptop (ASUS Zenbook UX430UNR/i7-8550U) won't wake when opening the lid or pressing a key, the only way to wake the laptop is pressing the power button. I also tested mainline (5.3.0-rc4 b7e7c85dc7b0) and 5.2.8 and the laptop wakes without issue when the lid is opened or a key is presed. > Please refer to the changelogs for details. > > Thanks, > Rafael > > >