Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp151987ybl; Fri, 16 Aug 2019 21:04:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1sCc5z1IOkQrtWOUupPFqdMv3M9XdBNcz1/Yu24kh6hY6SmWH5JuKJ/ALcaH/TFBYLXT0 X-Received: by 2002:a63:181:: with SMTP id 123mr10734406pgb.63.1566014698344; Fri, 16 Aug 2019 21:04:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566014698; cv=none; d=google.com; s=arc-20160816; b=PC9+01yrT7hDCvq2ykhavAoN6b66JUUAU9Lp8EwkG+G6wgiLfTlnbu/rKNfy3X2H9b S/rVGW4VY0w/j94l0Z5QsN8sybS+v6+NZfa5P0horZcSjfRA3RGfeGb+xu+88oiYDxLL hKPfJMd8Tiw1ZvPCNo0YJe36ky+oMDMM7J11i0T/ueTjAVrYrR/rKuRKFAPDzB9dnGRi cxZLazMejmrQQDpMJLRsBX8ypOjLquv4JXTRKhrtMT+OB38uQ46cRjKaEE1plCiT1XXW f/gmPH9xCJAbp/rR6xYV2aivca10dFQt1GwBiZQYuiwRK9Bz/42y3IEDDksozqGWp27D 4Rnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :message-id:dkim-signature; bh=LsFrOXJq15XZL37B55TOHg13GB/6UlZAx1tf1mF0vgE=; b=Viv3CniixUTlmX6SCKOWsLQNP1xpQViz0DVmoRTxx/Zb6qCJ4tnCKym+xVdit/1Pjj PpnJb6dm0OtOv39Prx0GgNaQYfr7jn1lzIzbIoyVxooCAEw+LP5pxuwlP21sX5QKOEMu xRt7X1Jvu6dxhlNq/zHHnjv1MVK0nz33TtZ9uZvHXx7u4+fjAJQ2VHlfGVgndOjst9JG GHuLzxvhA6GN6++W6WE6hczf+kZ7OuvVxE5vdZGQGWjZUAgBr5jtn0EuS9WwG9hPfoI2 S0OfTcRvIHSp9raNXowAxYXXAGETfGtcqHVt8KilccWJHsRgHmZl4HSLnn9UtQmkKNAv 37LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=faHrnHBH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si5808273pfr.130.2019.08.16.21.04.38; Fri, 16 Aug 2019 21:04:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=faHrnHBH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726012AbfHQECX (ORCPT + 99 others); Sat, 17 Aug 2019 00:02:23 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43086 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfHQECX (ORCPT ); Sat, 17 Aug 2019 00:02:23 -0400 Received: by mail-pf1-f195.google.com with SMTP id v12so4100309pfn.10 for ; Fri, 16 Aug 2019 21:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:from:cc:to:user-agent:date; bh=LsFrOXJq15XZL37B55TOHg13GB/6UlZAx1tf1mF0vgE=; b=faHrnHBHHFMpMEb6WPW1+nTnesDz1k1vxDrVmWiZDh6DGc+ePIs/A4rC5ua7wCnjsN 6oJlKKHuYI0LyHzNdxLwNjrgA8REbzNM5PfkbmB1cgHZwWF8ZD1Nu1f+nY5S0GttejAJ F6Ut5MOszAOmYBeuhxLGBHBPzgNE1VC1CWxWk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:from:cc:to :user-agent:date; bh=LsFrOXJq15XZL37B55TOHg13GB/6UlZAx1tf1mF0vgE=; b=blrFVh/R+pmqLogw1tzz1oLOXidOc5tDCHyAi6JDeWBccJDkaTiijpeNfxZyeBxZ7p r8omh1ujCvvN0N9fUJ9Z+Qh0KdZRQIHPjGOcNgP3DZUnoQ6Vg73AYb3mh4Pqai3QUWY4 a4AjRmxYdbZKYADPhK4sVQuzFl7i66nVx5pX+Q1ELh7HSgeQBA8EcUKKYtXUbQ/NZ8c6 sfzwih4NVIIctDn32LyaKqzhtpjhzVJoa+p1wP3WA4heE9pYfJTH6hnRLUD5ghhAXmW0 dHIdCebBFiFVW+nLvS4a+EkNB+QuLGwQ91r2b3+XmG6WamyAG6TH+5kACwbBMHLaKIaQ PBWA== X-Gm-Message-State: APjAAAUPzJC7B1rKZGOQn+7Lcdhnp3v7NTKhKY/dC3Ej8L+64KCf1N3N /X3slLkYaXyXk7/FmiBM0Rwo4Q== X-Received: by 2002:a17:90a:d34f:: with SMTP id i15mr10530619pjx.42.1566014542750; Fri, 16 Aug 2019 21:02:22 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id b24sm7420547pfd.91.2019.08.16.21.02.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 21:02:22 -0700 (PDT) Message-ID: <5d577c4e.1c69fb81.f3557.6783@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <355cd15c91e02716140d7114fd403559487b66b6.1564091601.git.amit.kucheria@linaro.org> References: <355cd15c91e02716140d7114fd403559487b66b6.1564091601.git.amit.kucheria@linaro.org> Subject: Re: [PATCH 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe From: Stephen Boyd Cc: linux-pm@vger.kernel.org To: Amit Kucheria , Andy Gross , Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , andy.gross@linaro.org, bjorn.andersson@linaro.org, edubezval@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: alot/0.8.1 Date: Fri, 16 Aug 2019 21:02:21 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Amit Kucheria (2019-07-25 15:18:37) > Move platform_set_drvdata up to avoid an extra 'if (ret)' check after > the call to tsens_register. >=20 > Signed-off-by: Amit Kucheria > --- Reviewed-by: Stephen Boyd