Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 17 Aug 2019 16:41:24 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Christoph Hellwig <hch@lst.de>, Jason Gunthorpe <jgg@mellanox.com>,
        Christoph Hellwig <hch@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= <thomas@shipmail.org>,
        Jerome Glisse <jglisse@redhat.com>,
        Steven Price <steven.price@arm.com>,
        Linux-MM <linux-mm@kvack.org>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Minchan Kim <minchan@kernel.org>
Subject: Re: cleanup the walk_page_range interface
Message-ID: <20190817164124.683d67ff@canb.auug.org.au>
In-Reply-To: <20190816140623.4e3a5f04ea1c08925ac4581f@linux-foundation.org>
References: <20190808154240.9384-1-hch@lst.de>
        <CAHk-=wh3jZnD3zaYJpW276WL=N0Vgo4KGW8M2pcFymHthwf0Vg@mail.gmail.com>
        <20190816062751.GA16169@infradead.org>
        <20190816115735.GB5412@mellanox.com>
        <20190816123258.GA22140@lst.de>
        <20190816140623.4e3a5f04ea1c08925ac4581f@linux-foundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/yU+iNNy5O7f5Ky43FGaKJK1";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/yU+iNNy5O7f5Ky43FGaKJK1
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Fri, 16 Aug 2019 14:06:23 -0700 Andrew Morton <akpm@linux-foundation.org=
> wrote:
>
> On Fri, 16 Aug 2019 14:32:58 +0200 Christoph Hellwig <hch@lst.de> wrote:
>=20
> > On Fri, Aug 16, 2019 at 11:57:40AM +0000, Jason Gunthorpe wrote: =20
> > > Are there conflicts with trees other than hmm?
> > >=20
> > > We can put it on a topic branch and merge to hmm to resolve. If hmm
> > > has problems then send the topic on its own? =20
> >=20
> > I see two new walk_page_range user in linux-next related to MADV_COLD
> > support (which probably really should use walk_range_vma), and then
> > there is the series from Steven, which hasn't been merged yet. =20
>=20
> Would it be practical to create a brand new interface with different
> functions names all in new source files?  Once all callers are migrated
> over and tested, remove the old code?

I certainly prefer that method of API change :-)
(see the current "keys: Replace uid/gid/perm permissions checking with
an ACL" in linux-next and the (currently) three merge fixup patches I
am carrying.  Its not bad when people provide the fixes, but I am no
expert in most areas of the kernel ...)
--=20
Cheers,
Stephen Rothwell

--Sig_/yU+iNNy5O7f5Ky43FGaKJK1
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1XoZQACgkQAVBC80lX
0Gx26Qf+Mrpwo57HDnrmpbDvtJAnQrIWM4inlDkl3Iu+YmyFE8EHher8hI0V7ak/
/iF78ubLfNWcDW1yffWNh7Cmor5Pbi7tSegB66lEJHrwnZX420rSEI6Zqho+xQvW
D5+VL/7LkCrtHb5CWXiJ3tWplUQ79bysPwD51Ya9XN49wczUkJy6WmESooHYy0uI
zW5H+TlsDOea9rTIKkYjFwdJqpbhpCbm2kx3nxFu7+cjXnt5aUMrQr7oOn/m8nch
FavqnC3phbmYVJ6mw6Na4PuNshZzah2Uz80Wmz9s7iG/czAsxuRcHHiRK+x+KSUL
Xgzpyg+dWsE7kUNT5c4kf7Miy8facQ==
=ykR8
-----END PGP SIGNATURE-----

--Sig_/yU+iNNy5O7f5Ky43FGaKJK1--