Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp271948ybl; Sat, 17 Aug 2019 00:05:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqx+11BZWfTlAq6rkPP+/nAiWI/DbvoZk5g6dbNi7kxXta9haYQOYgF46Qet+ZX0kCqG3Xgd X-Received: by 2002:a17:902:ba96:: with SMTP id k22mr13242972pls.44.1566025539488; Sat, 17 Aug 2019 00:05:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566025539; cv=none; d=google.com; s=arc-20160816; b=rpXgKMwFREmypKoUXS+/5oNObGa6h1XIkaLdJ468MW4iasfzPpYLY6IybvkKGSmVLr azSaYRogGmpJGRyClkp4HJYxcO9kTbEIOiZhNb7EUyvxIDg1SH5p0Ns9F75dQShnNV8y S/6s37m41TOlCfOxjtiLKk0eyj1TTvDPxRU2d1TnWDElEYlAlZmIAFmIDMCgNdoFX8lE gZ1P+IhyxfyawiEOqIJZSg0V6gjpf/JrFnnH6SjGeJXRu5sy1fu1wPqSBsl8eGl08nQN yxaZaNxGWfJnjBRsVtXXB/pHj1wJksvz5B29T16B+KRgUmHUqs76IrtfdSW+Xcf6INpC JgtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=GaE8AdPWP2CvtbUBOKaQC7z0Y9OZpgy5HIC4jNxXiLY=; b=i4feQBcc0iUAgC8Z4FRjeSX0Bc+ksDNRm+E0QtqPA8EfXh1ClKhcEIbiFL7pA4RlSW bR5j/ns/p4fJggm2WyUoJSHrpDoGB0ORxFNlbg8MfOlsd7HwAOEWirQM/SoIDmYiHjLC SbNeJOSYFkzZXzFGKHWAHsTdE1GFrwKwsc1dQ7exmPD4KzM4otuudRZF0RG1jcdHclmS RALf1a9Otj2CtbLc4FMDHtSKSCu9DPFizl5w55e9Xw7MFfkOC76xJdZsiN1GHD39ngMc FDwKNk0ohkh4sM11fwJUXa8+3Hpnestq4TrD2OkhXWj3FvtCZik1hhv7+ckBbJ3PVDrs i63A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x187si6026660pfd.200.2019.08.17.00.05.25; Sat, 17 Aug 2019 00:05:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbfHQHEO (ORCPT + 99 others); Sat, 17 Aug 2019 03:04:14 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:33411 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbfHQHEO (ORCPT ); Sat, 17 Aug 2019 03:04:14 -0400 Received: by mail-yb1-f195.google.com with SMTP id b16so2718542ybq.0; Sat, 17 Aug 2019 00:04:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=GaE8AdPWP2CvtbUBOKaQC7z0Y9OZpgy5HIC4jNxXiLY=; b=ZIh4ge7ncwF8PdNblZ261J7bYxaRtFPDQBpOp5cnq/jDgSOXxX8QdpLmWtC5wsLEdU aZ83EfRWbCz2jPeoW3M39YGHmQGV1CSKA1n6/EsbJeQyZONTFGKUJCsozCtMj4qzLX2d 3wxiLf4ogiKHE2ztCAObjLCH+nKViz61uecCyqZbbV0gU31oyVJjt4sTizWUO6wNilzv K+QdO2XEgRiZ5avavzIstsPKXShYjY+f3RqNwSBNLnwiIce5iOU8asuGH3SXkjcI2LGN +6xOug+F0gMYhRTzLNDffhH2F2jkZfRA/dvjkIEfV36FPPDF6wSZCIMfzChrYRLZwul1 81OQ== X-Gm-Message-State: APjAAAWte0kOhH753PvkNXe5rq8lDVUKV4L886PBHPeX9H7suX9C6yPN Pdvt8PRa1OK3LzalUQ0TXE4= X-Received: by 2002:a25:be87:: with SMTP id i7mr10081044ybk.388.1566025453049; Sat, 17 Aug 2019 00:04:13 -0700 (PDT) Received: from localhost.localdomain (24-158-240-219.dhcp.smyr.ga.charter.com. [24.158.240.219]) by smtp.gmail.com with ESMTPSA id u191sm2128754ywf.74.2019.08.17.00.04.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Aug 2019 00:04:12 -0700 (PDT) From: Wenwen Wang To: Wenwen Wang Cc: Mauro Carvalho Chehab , Thomas Gleixner , Richard Fontana , Greg Kroah-Hartman , Allison Randal , linux-media@vger.kernel.org (open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: dvb-frontends: fix a memory leak bug Date: Sat, 17 Aug 2019 02:04:04 -0500 Message-Id: <1566025445-5383-1-git-send-email-wenwen@cs.uga.edu> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In cx24117_load_firmware(), 'buf' is allocated through kmalloc() to hold the firmware. However, if i2c_transfer() fails, it is not deallocated, leading to a memory leak bug. Signed-off-by: Wenwen Wang --- drivers/media/dvb-frontends/cx24117.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-frontends/cx24117.c index 42697a5..9fccc90 100644 --- a/drivers/media/dvb-frontends/cx24117.c +++ b/drivers/media/dvb-frontends/cx24117.c @@ -619,8 +619,10 @@ static int cx24117_load_firmware(struct dvb_frontend *fe, /* send fw */ ret = i2c_transfer(state->priv->i2c, &msg, 1); - if (ret < 0) + if (ret < 0) { + kfree(buf); return ret; + } kfree(buf); -- 2.7.4