Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp1848769ybl; Sun, 18 Aug 2019 11:54:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxeHV6G7Pw5V2uCOGXao7Y2vRpeaJibw/Dz3q3U5sh/FT5XXhdbwQqj6DwTN4tNOMPHuQHS X-Received: by 2002:aa7:8a04:: with SMTP id m4mr20533618pfa.65.1566154496487; Sun, 18 Aug 2019 11:54:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566154496; cv=none; d=google.com; s=arc-20160816; b=dfQnC3ZZsm3ssWzYRKnqGzeXWj7V82+PBHSYGRIrj/HhqPJ3TWQj511F92QaDhfti2 eI0my9ZNUWbRsSf+2uCV/JeUUYkGG3gA/cqrrAXvoR3HhPXYOrRrax9rZE5gGVkZWFv6 DvmKhnexlq/x3M5h3qK1oUhxpLBUf5yEZrlzbvv64TeuIfouOum0GUmsHQN7aRcrGj/3 rRuvNLhVPWQvCythIvIeMAyVHKA+GChEcFno7j0F4X1br6mHvIdFEtiitZa9EsbqRbIh zYV6U1pPasVfdmcEP825rjOO8jjJXSwS1v/AcyPfudzanJKFdT3Dgi2PHiO/X7H67090 6saw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=p4VhrIIR7fs7Yfhp6vX++rPRmUah2bxQsRfcRHzIoN4=; b=AFkDLyWr9MIun/ibxD/5XkTqiOZHBKADXoTZpv/NVJ4iWBRBCvNnObpOKi64ffpO66 sIArYW3pamWu9lneSLGWe37LHeHb8Eg0mRMfv8X5RdjCsmw42+pYI47hQ80kn2HD8Wky eYxqjp9Ka/rwGU9H1OqILMuc4JnNf+xZ3bmOfAPob6sYdfir/0H53KuM/KsBg17Q5zaf ak3m6Ce75UvPAP00fZaYU1w32uFGZcS9xgpF3SvJqQZaP8uocwUpzK5LuCWLd3naiV0T g71lblaKl9Z06v3czUCZiTghNpmEzPVwl6xsgNBtYH7hKt8qI2YUJTehnnAvB8hHsYAI wvag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si8333339pga.462.2019.08.18.11.54.41; Sun, 18 Aug 2019 11:54:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfHRSxx (ORCPT + 99 others); Sun, 18 Aug 2019 14:53:53 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42734 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfHRSxx (ORCPT ); Sun, 18 Aug 2019 14:53:53 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hzQJJ-0007nC-Eq; Sun, 18 Aug 2019 18:53:49 +0000 From: Colin King To: Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] NTB: ntb_transport: remove redundant assignment to rc Date: Sun, 18 Aug 2019 19:53:49 +0100 Message-Id: <20190818185349.15275-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variable rc is initialized to a value that is never read and it is re-assigned later. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 40c90ca10729..00a5d5764993 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -292,7 +292,7 @@ static int ntb_transport_bus_match(struct device *dev, static int ntb_transport_bus_probe(struct device *dev) { const struct ntb_transport_client *client; - int rc = -EINVAL; + int rc; get_device(dev); -- 2.20.1