Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>
To:     David Miller <davem@davemloft.net>
CC:     "wenwen@cs.uga.edu" <wenwen@cs.uga.edu>,
        linux-wimax <linux-wimax@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] wimax/i2400m: fix a memory leak bug
Thread-Topic: [PATCH v2] wimax/i2400m: fix a memory leak bug
Thread-Index: AQHVU6hH81gCZjl8EkOIBEVs8oU/ZacB4SwA//+eT0o=
Date:   Sun, 18 Aug 2019 22:22:19 +0000
Message-ID: <49AFD2AB-DCA4-470F-96AD-826FAEFDD616@intel.com>
References: <1565900991-3573-1-git-send-email-wenwen@cs.uga.edu>,<20190818.141158.218871786116375619.davem@davemloft.net>
In-Reply-To: <20190818.141158.218871786116375619.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This driver should be orphaned. 

While I can?t certainly say nobody is using it, the HW has not been sold for years and it hasn?t been brought to current LK standards. 

If your assesment is the code shall not be used, it?s then another argument towards disconnecting it. 

> On Aug 18, 2019, at 14:12, David Miller <davem@davemloft.net> wrote:
> 
> From: Wenwen Wang <wenwen@cs.uga.edu>
> Date: Thu, 15 Aug 2019 15:29:51 -0500
> 
>> In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
>> to hold the original command line options. Then, the options are parsed.
>> However, if an error occurs during the parsing process, 'options_orig' is
>> not deallocated, leading to a memory leak bug. To fix this issue, free
>> 'options_orig' before returning the error.
>> 
>> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
> 
> Applied, but... looking at the rest of this file I hope nobody is actually
> running this code.