Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190816101944.3586-1-wangzqbj@inspur.com>
In-Reply-To: <20190816101944.3586-1-wangzqbj@inspur.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Mon, 19 Aug 2019 02:20:10 +0000
Message-ID: <CACPK8XegTePdmykMzZHnW=g6hyEGr7jiW3TP8AvdzSwZGr=2gA@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] hwmon: pmbus: Add Inspur Power System power supply driver
To:     John Wang <wangzqbj@inspur.com>
Cc:     Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Corbet <corbet@lwn.net>, linux-hwmon@vger.kernel.org,
        linux-doc@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        duanzhijia01@inspur.com, Lei YU <mine260309@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 16 Aug 2019 at 10:19, John Wang <wangzqbj@inspur.com> wrote:
>
> Add the driver to monitor Inspur Power System power supplies
> with hwmon over pmbus.
>
> This driver adds sysfs attributes for additional power supply data,
> including vendor, model, part_number, serial number,
> firmware revision, hardware revision, and psu mode(active/standby).
>
> Signed-off-by: John Wang <wangzqbj@inspur.com>

> +static const struct i2c_device_id ipsps_id[] = {
> +       { "inspur_ipsps1", 0 },

Convention would be to use "ipsps" here, instead of "vendor_device"?
> +       {}
> +};
> +MODULE_DEVICE_TABLE(i2c, ipsps_id);
> +
> +static const struct of_device_id ipsps_of_match[] = {
> +       { .compatible = "inspur,ipsps1" },
> +       {}
> +};
> +MODULE_DEVICE_TABLE(of, ipsps_of_match);

Do we need the of match table? I thought the match on the device name
from the i2c table would be enough. I will defer to Guenter here
though.

Assuming the device tables are okay:

Reviewed-by: Joel Stanley <joel@jms.id.au>

Cheers,

Joel

> +
> +static struct i2c_driver ipsps_driver = {
> +       .driver = {
> +               .name = "inspur-ipsps",
> +               .of_match_table = ipsps_of_match,
> +       },
> +       .probe = ipsps_probe,
> +       .remove = pmbus_do_remove,
> +       .id_table = ipsps_id,
> +};