Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2267901ybl; Sun, 18 Aug 2019 22:29:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzA06kEKlHhYXv3N+PjXYkUZhbt9EAh/BuS582OyipK5NPE04OJs3HbIuc8jyADUDTqjvbK X-Received: by 2002:a65:4b89:: with SMTP id t9mr18015097pgq.55.1566192550196; Sun, 18 Aug 2019 22:29:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566192550; cv=none; d=google.com; s=arc-20160816; b=YtVtjFL83RTFgTzpEGgLczGrVhZPkod/wm979l+djjIutdp6HUjefREuQRq84zj6h0 sIMohoPS1DJZtLqtFUQ/w4FUukEJI1vEPdTuQ3ESv+XShS7UUOmjUflZ+kn5kfvBJLEa kBTM6395wsgDtIjOkg10//dvWrd2+TEqt/8IHOBRQNbPsOyxXEK8QJAS8E1c7OBTaztG f+BqgZzLCkeONisiEyO6Oe4dAHbLW7VTJkViCsEeG2NJOMhpP5q1Fj070gLufquh7WFn wc/7A1MA5Zk4WVbSQgfvYvbsGe/t66DwKoEKglZXVeVckDZFZVqiSCNgP/C4I+ZRe0wc YLmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7l8k+4ZG7nJeYzE1JpkjMn4gv50BKtJjEbGlchg6FkY=; b=Rm249/TWZw3pVGWz+iDE5D6R4GoA9k+oQOLeOoShuN3GhcWE+7t4jS4eVZl7yj6RE3 WOWbByU91fI9HoU1mVmzDcO99+3IJPIMP8RLcetFU588HPEz+YTdkl55qAXQyrEbiDTL /b1r0jeHdbhqDWpNhx18O9A2A9f7/kZeEjXeZSWDqig4z1HqLHVrF/H/RbTwApjhahfr 95bokwrrKW64V7F4AZSEvd2MgP+MVeQjlM+ZNmsrcLcuGRjv/YrpfGOfaCz8tc8YxnNz 6bfOJy2cP98zxzouE/NehggImqbjssQKbgha/5t5zgn3QLPmL5u2AEjinPHx0nqqNk1z 4WSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ron3YMkG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j25si9636629pfr.11.2019.08.18.22.28.54; Sun, 18 Aug 2019 22:29:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ron3YMkG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfHSF0X (ORCPT + 99 others); Mon, 19 Aug 2019 01:26:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:34956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfHSF0X (ORCPT ); Mon, 19 Aug 2019 01:26:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D50BC2087E; Mon, 19 Aug 2019 05:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566192382; bh=8mqL7sJqdV6/4rHKJ1fvbrxryWKzfYZx2UQm6cr+Lx4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ron3YMkGmgUjS73C5r6xf1opxCK0Kg8aRrcqfOSFCPFjhqR+lSRPKkKxtxWuotyZ9 cRtgbpGkjP8Ql46SBdHHIn2PMaXCC/8nNrjAvUcbckpVnniLEjf9hG/26UDt9sFrlv mol7mexXdm6LPwXLra4FZYgWTT6pmarJYUcDJ9do= Date: Mon, 19 Aug 2019 07:26:19 +0200 From: Greg KH To: "Zhao, Yakui" Cc: devel@driverdev.osuosl.org, x86@kernel.org, linux-kernel@vger.kernel.org, Jason Chen CJ , Jack Ren , Liu Shuo , Mingqiang Chi Subject: Re: [RFC PATCH 04/15] drivers/acrn: add the basic framework of acrn char device driver Message-ID: <20190819052619.GC915@kroah.com> References: <1565922356-4488-1-git-send-email-yakui.zhao@intel.com> <1565922356-4488-5-git-send-email-yakui.zhao@intel.com> <20190816070559.GB1368@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 12:02:33PM +0800, Zhao, Yakui wrote: > > > On 2019年08月16日 15:05, Greg KH wrote: > > On Fri, Aug 16, 2019 at 10:25:45AM +0800, Zhao Yakui wrote: > > > ACRN hypervisor service module is the important middle layer that allows > > > the Linux kernel to communicate with the ACRN hypervisor. It includes > > > the management of virtualized CPU/memory/device/interrupt for other ACRN > > > guest. The user-space applications can use the provided ACRN ioctls to > > > interact with ACRN hypervisor through different hypercalls. > > > > > > Add one basic framework firstly and the following patches will > > > add the corresponding implementations, which includes the management of > > > virtualized CPU/memory/interrupt and the emulation of MMIO/IO/PCI access. > > > The device file of /dev/acrn_hsm can be accessed in user-space to > > > communicate with ACRN module. > > > > > > Co-developed-by: Jason Chen CJ > > > Signed-off-by: Jason Chen CJ > > > Co-developed-by: Jack Ren > > > Signed-off-by: Jack Ren > > > Co-developed-by: Mingqiang Chi > > > Signed-off-by: Mingqiang Chi > > > Co-developed-by: Liu Shuo > > > Signed-off-by: Liu Shuo > > > Signed-off-by: Zhao Yakui > > > --- > > > drivers/staging/Kconfig | 2 + > > > > Also, your subject line for all of these patches are wrong, it is not > > drivers/acrn :( > > Thanks for the pointing out it. > > It will be fixed. > > > > > And you forgot to cc: the staging maintainer :( > > Do you mean that the maintainer of staging subsystem is also added in the > patch commit log? Did you not run scripts/get_maintainer.pl on your patches to determine who to send patches to? Always do that. > > As I have said with NUMEROUS Intel patches in the past, I now refuse to > > take patches from you all WITHOUT having it signed-off-by someone from > > the Intel "OTC" group (or whatever the Intel Linux group is called these > > days). They are a resource you can not ignore, and if you do, you just > > end up making the rest of the kernel community grumpy by having us do > > their work for them :( > > > > Please work with them. > > OK. I will work with some peoples in OTC group to prepare the better ACRN > driver. Thank you. greg k-h