Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2283899ybl; Sun, 18 Aug 2019 22:50:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwYNoOh8UToaw+xbT6EfHrcVRivA8J3/4n34ei+8eWS+dGHtprEpjhp7YoDSz1/ih5a+TdG X-Received: by 2002:a63:f91c:: with SMTP id h28mr17495233pgi.397.1566193845235; Sun, 18 Aug 2019 22:50:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566193845; cv=none; d=google.com; s=arc-20160816; b=sNhsAkGv1ZAj59gQeD+u7UXoxAji3K8rDAI9Zvy8LmG0mMHx5MVe9/tCE1+x4sB3Kd sFAPZXOa7FsoyGN1GjOty1gfjFsyiQfw0Pvat9yE9Xm2gphRglx2XXaLvn6GCIJWwWnp MBwKODrOVD+zXPn5pMvxsqp85X+VrWLge2fYVH7qms9mpBkjmZgIupYt9vyTZVyd7q4E kOsNVqzkItitf2/7bPxELPS0OEsFSa70WHgSAk+kvSO2xX5LpcLJA/NjEGzJSiO5zkQH T7gUt0FH/gKQejXTRx0Ag7Pmy/agMVpTSRH0uWAXGlyL0eB0dM1GuDwRCT8z6ZDqHHsM sIyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:to:subject :from; bh=z8ye+IKSZBgZvVbw9UATk2rxDqWmPqRuieZWXGKbl+M=; b=r4LpL0WDerm9ANvaRmv0BUfMj3eP9xSYh6AWZgSgLKrsGN938oN5TAWKgu7sErENGR 0M3svrgIGcAYuCwoSZVMhychpwgAvZFsSNQoe/JscOWDDM6AXvhJ/nq1gLA4lQKJkZd2 BDJtPfPgx02PpjfDbl7g/8NU0uo01QfvQVCpu6dN9IjSAxtN6MNyHuG2HtK0S5q4XgPP mj59mQYzK/Ph0rAipnp6kiKTyNO5dbPWH2yJl5OuaoP+DOjqO9XiyXfu0EWKaZjk6SKr TuwyFtQSOsJtCezJkCFK5cFxnQtHdYJcGLBveMEYHP8U9b7zGPCU05wOoFqJlbDYdmpw R8KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r33si8167594pjb.42.2019.08.18.22.50.30; Sun, 18 Aug 2019 22:50:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbfHSFsc (ORCPT + 99 others); Mon, 19 Aug 2019 01:48:32 -0400 Received: from relay.sw.ru ([185.231.240.75]:38052 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfHSFsc (ORCPT ); Mon, 19 Aug 2019 01:48:32 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1hzaWq-0008BZ-FZ; Mon, 19 Aug 2019 08:48:28 +0300 From: Vasily Averin Subject: [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill() To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Miklos Szeredi Message-ID: Date: Mon, 19 Aug 2019 08:48:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently fuse_writepages_fill() calls get_fuse_inode() few times with the same argument. Signed-off-by: Vasily Averin --- fs/fuse/file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/fuse/file.c b/fs/fuse/file.c index e076c2cf65b0..bc9b64ef7b5d 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1874,7 +1874,7 @@ static int fuse_writepages_fill(struct page *page, if (!data->ff) { err = -EIO; - data->ff = fuse_write_file_get(fc, get_fuse_inode(inode)); + data->ff = fuse_write_file_get(fc, fi); if (!data->ff) goto out_unlock; } @@ -1919,8 +1919,6 @@ static int fuse_writepages_fill(struct page *page, * under writeback, so we can release the page lock. */ if (data->req == NULL) { - struct fuse_inode *fi = get_fuse_inode(inode); - err = -ENOMEM; req = fuse_request_alloc_nofs(FUSE_REQ_INLINE_PAGES); if (!req) { -- 2.17.1