Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <0cb35e79fef09b12af2c3448ac4cccfda2d205eb.1562578282.git.fthain@telegraphics.com.au>
In-Reply-To: <0cb35e79fef09b12af2c3448ac4cccfda2d205eb.1562578282.git.fthain@telegraphics.com.au>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 19 Aug 2019 13:27:58 +0200
Message-ID: <CAMuHMdVSGCdoDeWmQtYpx5+U51i=j4VHK+RC+=zSWEMpnF_1Cg@mail.gmail.com>
Subject: Re: [PATCH v2] m68k/mac: Revisit floppy disc controller base addresses
To:     Finn Thain <fthain@telegraphics.com.au>
Cc:     Laurent Vivier <lvivier@redhat.com>,
        Joshua Thompson <funaho@jurai.org>,
        linux-m68k <linux-m68k@lists.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 8, 2019 at 11:34 AM Finn Thain <fthain@telegraphics.com.au> wrote:
> Rename floppy_type macros to make them more consistent with the scsi_type
> macros, which are named after classes of models with similar memory maps.
>
> The MAC_FLOPPY_OLD symbol is introduced to change the relevant base
> address from 0x50F00000 to 0x50000000 (consistent with MAC_SCSI_OLD).
>
> The documentation for LC-class machines has the IO devices at offsets
> from $50F00000. Use these addresses for MAC_FLOPPY_LC (consistent with
> MAC_SCSI_LC) because they may not be aliased elsewhere in the memory map.
>
> Add comments with controller type information from 'Designing Cards and
> Drivers for the Macintosh Family', relevant Developer Notes and
> http://mess.redump.net/mess/driver_info/mac_technical_notes
>
> Adopt phys_addr_t to avoid type casts.
>
> Cc: Laurent Vivier <lvivier@redhat.com>
> Cc: Joshua Thompson <funaho@jurai.org>
> Tested-by: Stan Johnson <userm57@yahoo.com>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> Acked-by: Laurent Vivier <lvivier@redhat.com>

Thanks, applied and queued for v5,4.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds