Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4] media: si2168: Refactor command setup code
From:   Marc Gonzalez <marc.w.gonzalez@free.fr>
To:     Antti Palosaari <crope@iki.fi>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sean Young <sean@mess.org>, Brad Love <brad@nextdimension.cc>
Cc:     linux-media <linux-media@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= <j.neuschaefer@gmx.net>
References: <06171488-7530-d4e4-1b94-f82905ed383d@free.fr>
Message-ID: <499bea86-f483-f776-4512-510c5df9d78f@free.fr>
Date:   Mon, 19 Aug 2019 13:54:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <06171488-7530-d4e4-1b94-f82905ed383d@free.fr>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15/07/2019 11:50, Marc Gonzalez wrote:

> Use cmd_init() to fill a struct si2168_cmd command.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> Changes from v1:
> - Use a real function to populate struct si2168_cmd *cmd, and a trivial
> macro wrapping it (macro because sizeof).
> Changes from v2:
> - Fix header mess
> - Add Jonathan's tag
> Changes from v3:
> - Drop Jonathan's tag after rewrite
> - Completely drop macro, and explicitly provide 'wlen' argument
> ---
>  drivers/media/dvb-frontends/si2168.c | 152 ++++++++-------------------
>  1 file changed, 44 insertions(+), 108 deletions(-)

Brad, Sean, Antti,

I believe this patch is good to go. Is anything still wrong with it?

Regards.