Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2658057ybl; Mon, 19 Aug 2019 05:41:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQ2DkkmzR0Ny9AADpN6IYNx4rdpCvzcfLBfXs5shDVi1BX+tjswIHZoFLFTv8ZFlejC0iD X-Received: by 2002:a65:6256:: with SMTP id q22mr19753138pgv.408.1566218509759; Mon, 19 Aug 2019 05:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566218509; cv=none; d=google.com; s=arc-20160816; b=XLM7asH0T5erIJEH/TDLGbE8gvhqoZamXv340Sh1N7t4IXcW0w+oIFzbkMH3+ReumR 7YNf2fEsGvZSPDf6RY7ojBgw4Ea/o53vXNk2T6MFcD0/wN3PKCnpC064F3wkSSlmvfYM k+0JB06e4oYeh0Ols+HAfbzdD9lkd+2Ms24ft2nOdoUTMHeA/Noa7xzMmRRK1qQy9hAG x7gRPh/u4yLCiD3jnREGLe26LO0gpLUoN9hvABIFcX8GcyKdDPgnhIwG+XOLjsfiLO03 FiDQvcVy4HGA0CC44zAVS/FRnaUDYIwLurBufckr4+j8Xmfz58vUH5hK9yFNfLSEOk6K bi+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=r6lu+CGpNanpS1k58K50AemEOPT+ZZ8qWpSbLoRqMyg=; b=aPaDWXmue95icyF1Aqrp19IOrwMQs46CtdORqvdlibG9JOfUbjZ1bsqS6kF3ZUmPtB 5P0nrqhd0dG/e+KbGKCCeSzOe0IerOPg8lkG8rEjyBL9d+ZCdVrwvr6MjhfY69LZLMdk kJBQYlJJe4I9lCKFYIA9NZpnQ/xuitX5uJBUzSazKrBY7LqWAobwMB7EcSumg7w0BNze CZttjIFDYRQ7usSnLh6EuIBSe/i8xcqcQ2JJ11dRiNXPXJW6H7m9fHcQlrpXK7aqmrwn O1MB7XCABqdb/EzkQd5j8SjcVaa8pAaYxBm6GuVq4/OeHXQEG1BnhG4elOa0STl586A3 ZVYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cpidswUy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i24si9795979pgh.224.2019.08.19.05.41.34; Mon, 19 Aug 2019 05:41:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cpidswUy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbfHSMil (ORCPT + 99 others); Mon, 19 Aug 2019 08:38:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:34024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbfHSMil (ORCPT ); Mon, 19 Aug 2019 08:38:41 -0400 Received: from localhost (lfbn-ncy-1-174-150.w83-194.abo.wanadoo.fr [83.194.254.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C88E02085A; Mon, 19 Aug 2019 12:38:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566218320; bh=eQNahmOy+YOa70o8hxUX1/wwoHoUbdXOo6roeegsQow=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cpidswUycCY0vFKSKTaIBQdWf+F18sTgCc8BYCJ2tD56TtVawYSEF8+h7Ys9LnowC hdl3hCORNQ1tZ9deitnOIl60UY0Uk31Q4jdmszcNVuNvQTK1HpSAiwSE1QSc9HyxTs DAyms2dvo5Ql8MxqTUlmiMV1JOaa0PlDR4Rm5fEM= Date: Mon, 19 Aug 2019 14:38:38 +0200 From: Frederic Weisbecker To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, rcu@vger.kernel.org, "Paul E. McKenney" Subject: Re: [PATCH -rcu dev 1/3] rcu/tree: tick_dep_set/clear_cpu should accept bits instead of masks Message-ID: <20190819123837.GC27088@lenoir> References: <20190816025311.241257-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190816025311.241257-1-joel@joelfernandes.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 15, 2019 at 10:53:09PM -0400, Joel Fernandes (Google) wrote: > This commit fixes the issue. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/tree.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 0512de9ead20..322b1b57967c 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -829,7 +829,7 @@ static __always_inline void rcu_nmi_enter_common(bool irq) > !rdp->dynticks_nmi_nesting && > rdp->rcu_urgent_qs && !rdp->rcu_forced_tick) { > rdp->rcu_forced_tick = true; > - tick_dep_set_cpu(rdp->cpu, TICK_DEP_MASK_RCU); > + tick_dep_set_cpu(rdp->cpu, TICK_DEP_BIT_RCU); Did I suggest you to use the _MASK_ value? That was a bit mean. Sorry for all that lost debugging time :-(