Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
In-Reply-To: <20190819160502.GI5058@ziepe.ca>
Subject: Re: Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler warnings on 32-bit due
 to u64/pointer abuse
From:   "Bernard Metzler" <BMT@zurich.ibm.com>
To:     "Jason Gunthorpe" <jgg@ziepe.ca>
Cc:     "Geert Uytterhoeven" <geert@linux-m68k.org>,
        "Doug Ledford" <dledford@redhat.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 19 Aug 2019 16:29:11 +0000
MIME-Version: 1.0
Sensitivity: 
Importance: Normal
References: <20190819160502.GI5058@ziepe.ca>,<20190819150723.GH5058@ziepe.ca>
 <20190819141856.GG5058@ziepe.ca> <20190819135213.GF5058@ziepe.ca>
 <20190819122456.GB5058@ziepe.ca>
 <20190819100526.13788-1-geert@linux-m68k.org>
 <OF7DB4AD51.C58B8A8B-ON0025845B.004A0CF6-0025845B.004AB95C@notes.na.collabserv.com>
 <OFD7D2994B.750F3146-ON0025845B.004D965D-0025845B.004E5577@notes.na.collabserv.com>
 <OFD7C97688.66331960-ON0025845B.005081B6-0025845B.0051AF67@notes.na.collabserv.com>
 <OFB73D0AD1.A2D5DDF4-ON0025845B.00545951-0025845B.00576D84@notes.na.collabserv.com>
Content-Transfer-Encoding: 8BIT
Content-Type: text/plain; charset=UTF-8
Message-Id: <OFFE3BC87B.CF197FD5-ON0025845B.0059957B-0025845B.005A903D@notes.na.collabserv.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

-----"Jason Gunthorpe" <jgg@ziepe.ca> wrote: -----

>To: "Bernard Metzler" <BMT@zurich.ibm.com>
>From: "Jason Gunthorpe" <jgg@ziepe.ca>
>Date: 08/19/2019 06:05PM
>Cc: "Geert Uytterhoeven" <geert@linux-m68k.org>, "Doug Ledford"
><dledford@redhat.com>, linux-rdma@vger.kernel.org,
>linux-kernel@vger.kernel.org
>Subject: [EXTERNAL] Re: Re: Re: Re: [PATCH] RDMA/siw: Fix compiler
>warnings on 32-bit due to u64/pointer abuse
>
>On Mon, Aug 19, 2019 at 03:54:56PM +0000, Bernard Metzler wrote:
>
>> Absolutely. But these addresses are conveyed through the
>> API as unsigned 64 during post_send(), and land in the siw
>> send queue as is. During send queue processing, these addresses
>> must be interpreted according to its context and transformed
>> (casted) back to the callers intention. I frankly do not
>> know what we can do differently... The representation of
>> all addresses as unsigned 64 is given. Sorry for the confusion.
>
>send work does not have pointers in it, so I'm confused what this is
>about. Does siw allow userspace to stick an ordinary pointer for the
>SG list?

Right a user references a buffer by address and local key it
got during reservation of that buffer. The user can provide any
VA between start of that buffer and registered length. 

>
>The code paths here must be totally different, so there should be
>different types and functions for each case.

Yes, there is a function to process application memory (siw_rx_umem),
to process a kernel PBL (siw_rx_pbl), and one to process kernel
addresses (siw_rx_kva). Before running that function, the API
representation of the current SGE gets translated into target
buffer representation.

Thanks and best regards,
Bernard.