Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: Re: io.latency controller apparently not working
From:   Paolo Valente <paolo.valente@linaro.org>
In-Reply-To: <88488E82-E360-45B0-B010-209190D32892@linaro.org>
Date:   Mon, 19 Aug 2019 18:41:06 +0200
Cc:     linux-block <linux-block@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Jens Axboe <axboe@kernel.dk>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        noreply-spamdigest via bfq-iosched 
        <bfq-iosched@googlegroups.com>, Tejun Heo <tj@kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <FE51815E-787B-474C-A6B2-ABDC8853C772@linaro.org>
References: <22878C62-54B8-41BA-B90C-1C5414F3060F@linaro.org>
 <20190816132124.ggedqxrhi5povqlo@macbook-pro-91.dhcp.thefacebook.com>
 <1842D618-3E31-47FE-8B9C-F26BF1F5349C@linaro.org>
 <20190816175931.cxpdko44cuyq7trj@MacBook-Pro-91.local>
 <88488E82-E360-45B0-B010-209190D32892@linaro.org>
To:     Josef Bacik <josef@toxicpanda.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Il giorno 16 ago 2019, alle ore 20:17, Paolo Valente =
<paolo.valente@linaro.org> ha scritto:
>=20
>=20
>=20
>> Il giorno 16 ago 2019, alle ore 19:59, Josef Bacik =
<josef@toxicpanda.com> ha scritto:
>>=20
>> On Fri, Aug 16, 2019 at 07:52:40PM +0200, Paolo Valente wrote:
>>>=20
>>>=20
>>>> Il giorno 16 ago 2019, alle ore 15:21, Josef Bacik =
<josef@toxicpanda.com> ha scritto:
>>>>=20
>>>> On Fri, Aug 16, 2019 at 12:57:41PM +0200, Paolo Valente wrote:
>>>>> Hi,
>>>>> I happened to test the io.latency controller, to make a comparison
>>>>> between this controller and BFQ.  But io.latency seems not to =
work,
>>>>> i.e., not to reduce latency compared with what happens with no I/O
>>>>> control at all.  Here is a summary of the results for one of the
>>>>> workloads I tested, on three different devices (latencies in ms):
>>>>>=20
>>>>>           no I/O control        io.latency         BFQ
>>>>> NVMe SSD     1.9                   1.9                0.07
>>>>> SATA SSD     39                    56                 0.7
>>>>> HDD          4500                  4500               11
>>>>>=20
>>>>> I have put all details on hardware, OS, scenarios and results in =
the
>>>>> attached pdf.  For your convenience, I'm pasting the source file =
too.
>>>>>=20
>>>>=20
>>>> Do you have the fio jobs you use for this?
>>>=20
>>> The script mentioned in the draft (executed with the command line
>>> reported in the draft), executes one fio instance for the target
>>> process, and one fio instance for each interferer.  I couldn't do =
with
>>> just one fio instance executing all jobs, because the weight =
parameter
>>> doesn't work in fio jobfiles for some reason, and because the ioprio
>>> class cannot be set for individual jobs.
>>>=20
>>> In particular, the script generates a job with the following
>>> parameters for the target process:
>>>=20
>>> ioengine=3Dsync
>>> loops=3D10000
>>> direct=3D0
>>> readwrite=3Drandread
>>> fdatasync=3D0
>>> bs=3D4k
>>> thread=3D0
>>> filename=3D/mnt/scsi_debug/largefile_interfered0
>>> iodepth=3D1
>>> numjobs=3D1
>>> invalidate=3D1
>>>=20
>>> and a job with the following parameters for each of the interferers,
>>> in case, e.g., of a workload made of reads:
>>>=20
>>> ioengine=3Dsync
>>> direct=3D0
>>> readwrite=3Dread
>>> fdatasync=3D0
>>> bs=3D4k
>>> filename=3D/mnt/scsi_debug/largefileX
>>> invalidate=3D1
>>>=20
>>> Should you fail to reproduce this issue by creating groups, setting
>>> latencies and starting fio jobs manually, what if you try by just
>>> executing my script?  Maybe this could help us spot the culprit more
>>> quickly.
>>=20
>> Ah ok, you are doing it on a mountpoint.
>=20
> Yep
>=20
>> Are you using btrfs?
>=20
> ext4
>=20
>> Cause otherwise
>> you are going to have a sad time.
>=20
> Could you elaborate more on this?  I/O seems to be controllable on =
ext4.
>=20
>> The other thing is you are using buffered,
>=20
> Actually, the problem is suffered by sync random reads, which always
> hit the disk in this test.
>=20
>> which may or may not hit the disk.  This is what I use to test =
io.latency
>>=20
>> https://patchwork.kernel.org/patch/10714425/
>>=20
>> I had to massage it since it didn't apply directly, but running this =
against the
>> actual block device, with O_DIRECT so I'm sure to be measure the =
actual impact
>> of the controller, it all works out fine.
>=20
> I'm not getting why non-direct sync reads, or buffered writes, should
> be uncontrollable.  As a trivial example, BFQ in this tests controls
> I/O as expected, and keeps latency extremely low.
>=20
> What am I missing?
>=20

While waiting for your answer, I've added also the direct-I/O case to
my test.  Now we have also this new case reproduced by the command
line reported in the draft.

Even with direct I/O, nothing changes with writers as interferers,
apart from latency becoming at least equal to the case of no I/O
control for the HDD.  Summing up, with writers as interferers (latency
in ms):

            no I/O control        io.latency         BFQ
NVMe SSD     3                     3                 0.2
SATA SSD     3                     3                 0.2
HDD          56                    56                13

In contrast, there are important improvements with the SSDs, in case
of readers as interferers.  This is the new situation (latency still
in ms):

            no I/O control        io.latency         BFQ
NVMe SSD     1.9                   0.08              0.07
SATA SSD     39                    0.2               0.7
HDD          4500                  118               11

Thanks,
Paolo

> Thanks,
> Paolo
>=20
>> Thanks,
>>=20
>> Josef