Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2953679ybl;
        Mon, 19 Aug 2019 09:50:12 -0700 (PDT)
X-Google-Smtp-Source: APXvYqy3Wu3tMC3uOgO/JEjt9LtoPON40zAEIg13cQjA14yTZSEhyUUjrfFXxGL59RojYZU7VOb7
X-Received: by 2002:a62:7d0d:: with SMTP id y13mr24235221pfc.150.1566233412185;
        Mon, 19 Aug 2019 09:50:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1566233412; cv=none;
        d=google.com; s=arc-20160816;
        b=WzitYq8MGHG3n3n/j+i1Y7JZNsQS1WMuxro8yDSqWwpGfYxUuANRDeU7PHxqfU931M
         34U4ZCJXbR6qNPrYlApYPeXg2+Ex/jNhitrq1eMf+gGB3OTpuasO5OFmW4O+TsIZU2e+
         RMtna2f0oS/49sqKMzvUROIVVCci2Slg5FJKrLLGUk+xI5JDVJbYTgnz22p/2TPBLOVK
         wXmp39NfL+1Je46sLzz/hSrINabwG+xEggP8EY5IYhiauFVf/r0O2YEf3/xC87SNBSM7
         tVbdKkhtv7w+SuBIlhuKykCR/OCTWWVC3zK+CaaGP1OlyFDQ1s98YrWzrduPUbv3eIE0
         EKcg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=5r3XqVK7uUsQV/llWAsJ+lLwxWZKYui1ernh/kc6CgI=;
        b=0uJ+Neka+YlQ6406ttXBPcerxxd1unHKq4tPvHLQc2jfMFbGnRMC2HRMY3lKgu01IF
         2nA1Cjhkjcsxte2AYGJhCe7tsNjWdzBg0R41Aul7XRWhZRxRalYDG6D0/riahqUbuKaq
         +MkaDDlUBAMHaxukgyT9OrEokNaZrZNQmSqR8D6i85AVBPdL4yyj1Uh+zo09x7DbORF9
         I7O9yH57k2/Wbft540oudUyKNicIHOPfANd1hbH7BBxTmWxw5OvmF/QJVxq7GRS+zQZL
         q0m4Ri1LpkWd/z1aLna15ggGzF0RFl3xjPNs7YAU7wq9hScxzRNDOv6fs7LA5rtkJDgb
         CO4Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=JxFov87L;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id r14si10115634pgm.406.2019.08.19.09.49.56;
        Mon, 19 Aug 2019 09:50:12 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=JxFov87L;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727744AbfHSQsR (ORCPT <rfc822;rajatbajpailinux@gmail.com>
        + 99 others); Mon, 19 Aug 2019 12:48:17 -0400
Received: from mail-lf1-f67.google.com ([209.85.167.67]:45849 "EHLO
        mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726879AbfHSQsR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Aug 2019 12:48:17 -0400
Received: by mail-lf1-f67.google.com with SMTP id a30so1888593lfk.12
        for <linux-kernel@vger.kernel.org>; Mon, 19 Aug 2019 09:48:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=5r3XqVK7uUsQV/llWAsJ+lLwxWZKYui1ernh/kc6CgI=;
        b=JxFov87LYvfBlgQIn7fHkeQlQaDh0lzTxae+saZVrzNE97zcgm2CNKSKxvMmFVaNSF
         /SSw8tj2LvjSGnCtn2btJubah9nsoxe66JrRDDFL1bWAY1vCPj1AXtQFzbKbYRLikM/V
         o8N9I1ATwyFd39Ut+oPs/x5LHd5U2q4kiDMySqv5NrMgkN7P5IR5X30ylKR21Yc7cwpY
         0nBHcXM4di24iig03wPqbQZEjHu5VW9k0fFEZcOkws580lCF+mgUWKpsX6t0Y5uPXVQv
         89PdH6xhEr1354GVLfFsksg7gFFnRNmbEOv173Dor06GVW/YPTC4nTxqfa+1TRgwTja1
         qi1g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=5r3XqVK7uUsQV/llWAsJ+lLwxWZKYui1ernh/kc6CgI=;
        b=jX2J85A5LeK164pMCBjKqu9vdhN2a6KsZpJ7LZ2ehOuIhSHw44QLDAE2QgHr6yaikN
         Qtvk6BtW9UX0xpQIW/Ge8zYwF7bgqR52aUyxMayogfN5iPlRb/pZYYN8t5UUTtFfZ542
         Kr7iiq5zBcO6D5AJ4sokh8COFwJa1KicH0egAxP4DJqqVCcYfhBQhuvPDe8fkd/3WS1t
         O0nvaJ17KzoJyIpZlUgtAGf0qHlh0sBikskotAriGvbYU9kcwDOKTSF8yDOSQ8COL07P
         QpNM9igwzZGjzjRBLUHie2fkfDZBBWw4TTUc3y0quTJWaMr2Bj8zlOvU/50S4M870S11
         12Ug==
X-Gm-Message-State: APjAAAXdxQIn82IRWVAwrMAP592Dw/R6qhcUKmwpHK23IlHAEJdSWUgJ
        EGzmc1Vzr2QRg9vafmsic6HXvHKN2LOb/Ts1xxo=
X-Received: by 2002:ac2:5a1c:: with SMTP id q28mr13521904lfn.131.1566233295354;
 Mon, 19 Aug 2019 09:48:15 -0700 (PDT)
MIME-Version: 1.0
References: <20190819075126.870-1-nishkadg.linux@gmail.com>
In-Reply-To: <20190819075126.870-1-nishkadg.linux@gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Mon, 19 Aug 2019 18:48:03 +0200
Message-ID: <CANiq72m5LsZKY-WU+63Rt9EfXW51SN-QGXg17AciounFQdsAPw@mail.gmail.com>
Subject: Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and
 ht16k33_fb_var constant
To:     Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc:     Robin van der Gracht <robin@protonic.nl>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 19, 2019 at 9:51 AM Nishka Dasgupta
<nishkadg.linux@gmail.com> wrote:
>
> The static structures ht16k33_fb_fix and ht16k33_fb_var, of types
> fb_fix_screeninfo and fb_var_screeninfo respectively, are not used
> except to be copied into other variables. Hence make both of them
> constant to prevent unintended modification.
> Issue found with
> Coccinelle.

Thanks Nishka, picking it up.

Cheers,
Miguel