Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2962156ybl; Mon, 19 Aug 2019 09:58:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxAxstoiPyPvFgwyWzSTCNxl2QblQF7Snm3WQrcQyZPmT/16bm8eJVZuTijRmN3LvqgVFo X-Received: by 2002:a17:90a:cc0c:: with SMTP id b12mr21122612pju.138.1566233894139; Mon, 19 Aug 2019 09:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566233894; cv=none; d=google.com; s=arc-20160816; b=QAuR26vuy2sNzX9pjwpo1eNXs8OoZR7iyYwv41KCX91aI2QxR5K7HxWUmzikylKGNg jshZLn/wOqoNhA3Gw1nM7c5hHG/xfjyMnEGRKY4MPr1INCgh55ZAIH/VICTHJ5ldxLRI fd3qsUORcB5NR+sKqby57esgSexaY74YXrKYuvziRCwRAl/nHgKkE/M0oN/LxR39fgW2 CK9uqc4dtTv8LJRCp5/PR2roDNSRM3Ww0oQxZkdPaNateVdL8DCapbzWUaTa9zWDzY1+ hyUXbH4wkd5MueKSdwbb2rJEGrcwiq5fu7PDgNzQuLLsMaEJd3rg/erXqLhSf66I4Ttb dR3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qL1v8gzoUdxGTq7qBsEG7ZXqbhHBbYg1cJHwXYyAc9s=; b=yziAH8ckcSBMb9gmwn0TnCH8j8ifNIKepOGStX97GrlthUgx5FRRdZaCL4jHcKWnwe +7Y6m3uPudlon6n9od910QZ+fWm0Au74OBuzmvm/IRpCtgLU/HvfyPnaFBUnUoxJ2c3L rQUKhVsdYyTfXru60JqBWMzLdxismDaazzb0wGEe22YryK3R3h7tVK2wYwSIwSWpYGFR r4BaQBdjYOBGxCNwSU/u0uvuaoiqbenLE8zimiTcoWCj8qnA/gDgqtQ/HsTjY1d/LTpa Zr1g4uPNM8xfDxIjbfT+Ql4PK3iLNqGlGY6a17Os4rzwwF/PAV2Lwpz9APeiyf86n7JT ylIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aQsWow5e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si10224861pld.224.2019.08.19.09.57.58; Mon, 19 Aug 2019 09:58:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aQsWow5e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbfHSQ5H (ORCPT + 99 others); Mon, 19 Aug 2019 12:57:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:51102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726525AbfHSQ5H (ORCPT ); Mon, 19 Aug 2019 12:57:07 -0400 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6CE9C22CED; Mon, 19 Aug 2019 16:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566233826; bh=J9Qn/aVNhFBb93Jqnzfg6I63rHYdO74sYQm4uyr9my0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aQsWow5e9kjAe5ypPL1Rm+4zrlD7JRZi9a2g8a2c3/W81hO6g0OYrWr0i1RhdsQ2t QFlzS8V5cXL8XRC4P3byVp31RfrFy9Xyvypk/14/hPyanl94SayeU3PjN8I4FNbv1T uFPK6bh29Vj6Kt1H0sJUac39L+wmG+zwM6hu18Ac= Received: by mail-qk1-f171.google.com with SMTP id 125so2003051qkl.6; Mon, 19 Aug 2019 09:57:06 -0700 (PDT) X-Gm-Message-State: APjAAAXvTuUfcK6LwCX153kA+mMaUEr+x91DJ19ZurcuuYXsvDLpdYjV 1r3xHCRUoUj0THtrfKWCKnDov0LZc9pPzLy8cg== X-Received: by 2002:a37:a48e:: with SMTP id n136mr22456622qke.223.1566233825565; Mon, 19 Aug 2019 09:57:05 -0700 (PDT) MIME-Version: 1.0 References: <20190814044814.102294-1-weiyongjun1@huawei.com> In-Reply-To: <20190814044814.102294-1-weiyongjun1@huawei.com> From: Rob Herring Date: Mon, 19 Aug 2019 11:56:53 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH -next] drm/panfrost: Fix missing unlock on error in panfrost_mmu_map_fault_addr() To: Wei Yongjun Cc: Tomeu Vizoso , David Airlie , Daniel Vetter , dri-devel , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 13, 2019 at 11:44 PM Wei Yongjun wrote: > > Add the missing unlock before return from function panfrost_mmu_map_fault_addr() > in the error handling case. > > Fixes: 187d2929206e ("drm/panfrost: Add support for GPU heap allocations") > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks. Rob