Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1566149993-2748-1-git-send-email-wenwen@cs.uga.edu> <e52a548a-0516-55ee-4005-5cc24c3a20b5@microchip.com>
In-Reply-To: <e52a548a-0516-55ee-4005-5cc24c3a20b5@microchip.com>
From:   Wenwen Wang <wenwen@cs.uga.edu>
Date:   Mon, 19 Aug 2019 13:03:53 -0400
Message-ID: <CAAa=b7cnsmMNPo+WCBtfKemP6G=Aau5SQBmDyFv-LuTdx5eeCw@mail.gmail.com>
Subject: Re: [PATCH] mtd: spi-nor: fix a memory leak bug
To:     Tudor Ambarus <Tudor.Ambarus@microchip.com>
Cc:     Marek Vasut <marek.vasut@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        "open list:NAND FLASH SUBSYSTEM" <linux-mtd@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        Wenwen Wang <wenwen@cs.uga.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 19, 2019 at 2:03 AM <Tudor.Ambarus@microchip.com> wrote:
>
>
>
> On 08/18/2019 08:39 PM, Wenwen Wang wrote:
> > In spi_nor_parse_4bait(), 'dwords' is allocated through kmalloc(). However,
> > it is not deallocated in the following execution if spi_nor_read_sfdp()
> > fails, leading to a memory leak. To fix this issue, free 'dwords' before
> > returning the error.
>
> Looks good. Would you add a Fixes tag?

Sure, I will add the Fixes tag and resubmit the patch. Thanks!

Wenwen

> >
> > Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 03cc788..a41a466 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -3453,7 +3453,7 @@ static int spi_nor_parse_4bait(struct spi_nor *nor,
> >       addr = SFDP_PARAM_HEADER_PTP(param_header);
> >       ret = spi_nor_read_sfdp(nor, addr, len, dwords);
> >       if (ret)
> > -             return ret;
> > +             goto out;
> >
> >       /* Fix endianness of the 4BAIT DWORDs. */
> >       for (i = 0; i < SFDP_4BAIT_DWORD_MAX; i++)
> >