Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp2995955ybl; Mon, 19 Aug 2019 10:27:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzDc6sfIZ6J+afx8qfTwAA7yG9x+yFS/HJXxkIuEFzogpm1jwMeOl/EduZN0pfksZjOtGr5 X-Received: by 2002:a17:902:524:: with SMTP id 33mr24090111plf.27.1566235638986; Mon, 19 Aug 2019 10:27:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566235638; cv=none; d=google.com; s=arc-20160816; b=LOdk3fArO9JTy7ScQX25uCs9dcSifRXva4Uy7RpSkBQMEumY24IkkR0/66+Q4ZRVaW fCIwKLwZWFVxK85KALiGnvKrrmm4XtU9fbNn8JbJomz9hgsRM74F4TqTWqbwNHRkn5Jv xuik6okcGHyS8tRZINdD6CtaLpOnBve0CLzfgfFc/4yDgV8uZFYfM7CmdF/eWhqxaGeA srEIRMEG+t9+ZvB5D7aV+O0ZYN6+dUDSjw+KnKwfT3RQgVCdu7mTO0pYB5/I4u/1eUt8 VRA0+RwB2AtXF4SHtemnkb/5D5bb5TiAzJcx5YSnJ4ZZp7HI3leYX7UoKKa0k1PMCKjg 6HRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UeBdDvPNrc05bYeveoPKdW3PCeyL2RSe4gN9buI5qTk=; b=f0V5Ec4r0m8K/PtrbvmFEKHxYChOB4Nur6h5Y62iJes6ymw89RaVOhlrVIFmLMcJor qSXmCl5170InOTL/BMdABUegBGy2WQ3hfbYdU3g7M9ON7S0Rx93OCd+LOGxAbyVgeyEQ NSH2C01OtnDLBTxMt+8WA4XE11KxDT63JMfSXvFmYw2v6l9BjBhP45hLOO2rCoItLgAI HbKfQwUnhJfW2s30BubPqfCeozX2vvR/wIcIQeYVrbHRwNDND3h6/2qhAliA6bqqbtOl jS7UPAGhp2WowBHcvD9taaZFz2CCOGKWZOMjne1hvMQ1ALeND4YqmpZp/QNLJPEoRADb agXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s19si10121468pgm.291.2019.08.19.10.27.03; Mon, 19 Aug 2019 10:27:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727981AbfHSRZq (ORCPT + 99 others); Mon, 19 Aug 2019 13:25:46 -0400 Received: from foss.arm.com ([217.140.110.172]:57722 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727524AbfHSRZq (ORCPT ); Mon, 19 Aug 2019 13:25:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9468C360; Mon, 19 Aug 2019 10:25:45 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 155553F246; Mon, 19 Aug 2019 10:25:44 -0700 (PDT) Date: Mon, 19 Aug 2019 18:25:43 +0100 From: Andrew Murray To: Krzysztof Wilczynski Cc: Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI/PCI: Remove surplus parentheses from a return statement Message-ID: <20190819172543.GA23903@e119886-lin.cambridge.arm.com> References: <20190819135324.29504-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819135324.29504-1-kw@linux.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 03:53:24PM +0200, Krzysztof Wilczynski wrote: > Remove unnecessary parentheses enclosing the value in a return > statement in the drivers/acpi/pci_link.c. > > Signed-off-by: Krzysztof Wilczynski > --- > drivers/acpi/pci_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c > index db11f7771ef1..00a6da2121be 100644 > --- a/drivers/acpi/pci_link.c > +++ b/drivers/acpi/pci_link.c > @@ -661,7 +661,7 @@ int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering, > ACPI_DEBUG_PRINT((ACPI_DB_INFO, > "Link %s is referenced\n", > acpi_device_bid(link->device))); > - return (link->irq.active); > + return link->irq.active; > } > > /* > @@ -712,7 +712,7 @@ int acpi_pci_link_free_irq(acpi_handle handle) > acpi_evaluate_object(link->device->handle, "_DIS", NULL, NULL); > > mutex_unlock(&acpi_link_lock); > - return (link->irq.active); > + return link->irq.active; It looks like these parentheses were left over after a patch that removed some macros: ad550d98d3317 ("ACPI: delete tracing macros from drivers/acpi/*.c") I can't see any you've missed so: Reviewed-by: Andrew Murray > } > > /* -------------------------------------------------------------------------- > -- > 2.22.1 >