Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3092390ybl; Mon, 19 Aug 2019 12:04:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpSo3WJLc/szaKLk5Pv7YDI2awIe1F4756GrUpWRwMOOLoAKD1m1POFoS4C7ofb/YUJxx8 X-Received: by 2002:aa7:8f2e:: with SMTP id y14mr25842112pfr.113.1566241483256; Mon, 19 Aug 2019 12:04:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566241483; cv=none; d=google.com; s=arc-20160816; b=POFRkCH3yQDo0LWtZ8eiRCyTO9iKnzztnIuGTh/BOg4CwSpMtlZei2kQivdG1PBEfK 9z6lfS4cC4CAotx3s1L4xFKWdhk80BGPyegIyJIAXtESGnZjpWSQC/VOwOekTTTLje1y FFpY2/HcnzR5KV2lubhGQrA+ozDQ6lvsriYIxqVtKVOXr/sywqQAIOSPDWp2A40iaBzg 5yzOcl3WVigIW81MbJNozXiib6xtN66Msh12+FPGYJEE3Jc1XgRepnUrtFJwQokQdolq 4+8QN07JQCH7mBOYN3ofVXDks7hasr9wvOvxSpgaQAyw+o4GFD1BXMze3rV5RJySMK6N eq0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=q4rnD2AOpR/95lDbnfWSHnN+HAD3xqLotj0pdJ8MO+M=; b=is2sm32Ym06pwR8BOkF4xQ/22ifm8vnGjNMu3hnUA9+HqL0l4vW4ne27so7THm/6yQ YoZUfhctsDMrHk4+6kxSuRnBip91ef8oljqubYwhJ7bAXxwTldcnz+MhwTNkzYi+Upe9 E+V2ybqXdc0O0NjbhyQGhoSqjjODpjxvxQGqJBJKmzMQQNcSiIaAanGGe3Bn4OiFi9+v HgKVgwmNkKSecnWerWm4NvKNQP+JmpqXxEdDqe4hYJ6BRfJ+eiMoxCTSDAMtt3Dbzs4Z L8QTXZGcmvB3R4O/25uf/btDTM96Bh4ON1uUTzJUkWcpZjIYQ/ZnXXUvkNwabZ5DlkXT 52UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=wcbRtEO1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si10499118pln.308.2019.08.19.12.04.27; Mon, 19 Aug 2019 12:04:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=wcbRtEO1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728202AbfHSTCM (ORCPT + 99 others); Mon, 19 Aug 2019 15:02:12 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37644 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728014AbfHSTCM (ORCPT ); Mon, 19 Aug 2019 15:02:12 -0400 Received: by mail-pf1-f195.google.com with SMTP id 129so1711529pfa.4 for ; Mon, 19 Aug 2019 12:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q4rnD2AOpR/95lDbnfWSHnN+HAD3xqLotj0pdJ8MO+M=; b=wcbRtEO1DusCAM1DvYyK7yjIacFwB4c4UdScyq0KyWRqUoBbeE5BKNXkLGisv9kBee p/OgJnoyojBTfv/j/fpknTzK56CUwtudc2AD1rnCkbjh7sSqFDdf3BhuMZxSbwcT71TY VvwOANzgfrA5q1DYG23XtR9vcMeohomgM4S5VNhkBEMhuXlftWBkoOEvo4BJUTXoXUD7 DW3e8p9TzLJ3Pa7Lg571PN81Iqj5sm8iVdxDhfhQnpdUOhjTBaPASWSeuSchn9vpxt7H nku1L7mOF/WO5sATX0KzvAg+GE0YDjfFsUd7z/aL5VHUfrYpjsVMp+aNf3Rm+dyC5Zbv DLBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q4rnD2AOpR/95lDbnfWSHnN+HAD3xqLotj0pdJ8MO+M=; b=hCqINNVFP95crE3v9GHo3T8e9QtOmDm9QSDfs2IZjDo4wfqUaRpVkdyGlft7Xk2MQN 2OrjXkbIqEs05aQ/3oUimWkMysAPLeASenWZNEd2QZGV5JJ878MLz2yOa3t/4J4wFLcf wbgaVkpMu66N/jXCGwwKHZt5YmF7Rqqk+bfmAW2xD2rp2BEfHL7gzcSmu8zLwZ+6lI0Z pUrJdHBe/RmVe1q2ZXt6tPfgv0iW9Z1rE6EWbq57DeeGRTHCjm7NndsATBUYrbdtr0aY OKCgaqS7/MT+3E54rmkenPvaiel+WnKAW911GnAGTEXtVdV3SO99atrafaZbA3NwV4+A 6HBQ== X-Gm-Message-State: APjAAAXsBzFuXTNKaMVFwWrYuFfrSLeay3LgQGKznkEahnRJU04k8AHJ AHKHCiKGio3VjJAbtHO2dO8XfA== X-Received: by 2002:aa7:9298:: with SMTP id j24mr24981971pfa.58.1566241331348; Mon, 19 Aug 2019 12:02:11 -0700 (PDT) Received: from ?IPv6:2620:10d:c081:1133::103e? ([2620:10d:c090:180::3970]) by smtp.gmail.com with ESMTPSA id s67sm15532333pjb.8.2019.08.19.12.02.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 12:02:10 -0700 (PDT) Subject: Re: [PATCH v3] nvme: Add quirk for LiteON CL1 devices running FW 22301111 To: Sagi Grimberg , Mario Limonciello , Keith Busch Cc: Christoph Hellwig , linux-nvme@lists.infradead.org, LKML , Ryan Hong , Crag Wang , sjg@google.com, Charles Hyde , Jared Dominguez References: <1565986579-10466-1-git-send-email-mario.limonciello@dell.com> From: Jens Axboe Message-ID: <3d01da80-be78-5ca6-6ef2-c0e44840118f@kernel.dk> Date: Mon, 19 Aug 2019 13:02:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/19 12:57 PM, Sagi Grimberg wrote: > > > On 8/16/19 1:16 PM, Mario Limonciello wrote: >> One of the components in LiteON CL1 device has limitations that >> can be encountered based upon boundary race conditions using the >> nvme bus specific suspend to idle flow. >> >> When this situation occurs the drive doesn't resume properly from >> suspend-to-idle. >> >> LiteON has confirmed this problem and fixed in the next firmware >> version. As this firmware is already in the field, avoid running >> nvme specific suspend to idle flow. >> >> Fixes: d916b1be94b6 ("nvme-pci: use host managed power state for suspend") >> Link: http://lists.infradead.org/pipermail/linux-nvme/2019-July/thread.html >> Signed-off-by: Mario Limonciello >> Signed-off-by: Charles Hyde >> --- > > Jens, can you please rebase for-linus so we have the needed dependency: > 4eaefe8c621c6195c91044396ed8060c179f7aae I just did as part of adding a new patch, being pushed out shortly. -- Jens Axboe