Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3120540ybl;
        Mon, 19 Aug 2019 12:33:20 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwwr6K9jBZANg4ZbB4gqRB7mNgvRosjCtVQ9Qtu/TW+CegoQ1vMFxpVqO2r/RLgYT6EwQ8v
X-Received: by 2002:a17:90a:18e:: with SMTP id 14mr22041960pjc.66.1566243200816;
        Mon, 19 Aug 2019 12:33:20 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1566243200; cv=none;
        d=google.com; s=arc-20160816;
        b=bPPtywkSKZQS2gnlWtwxUp/2HqFHXzQPamj+iKEqdrW603C+1eN3AyTHEkZik39I/H
         a0dI3lgX9pFyErY6Sxrb8xmeNwIv6iDlB4Ne6nQU1wVZtpolXIFg7e9CWuMV4VGXV5Ou
         mubvDDvamj5hfXjJ8G/GLq/O2Ott7DldmWfZU2NBoupPalxXQxt8N8Pd7VJ1XdNbjb9F
         m2Pb8XdBX/kuu6+3TDP+cLFiV6KCMVkihKRnk1AGubAVB/vYvORn52Kfh/mSl3dycygP
         2PFQEbufh/4prLCs5oouFs4SBuQBS3+Xk/0IORdzzwTYUV7on/pD8I04jgjxdOucr0Dt
         l/Pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=O1+zBKqCqZBRfmN9e8CVp5s+/FmYKv98YGRf5sf04P8=;
        b=t+60Wk8HMUmYCt55sQ62OmVnIQk9rbapU9WduuHpwQTd5VKUzsalS+XZVl8Biu1xPs
         k7/9UP2Tcb09jS4AUHkW536fY5Rx51bdR36JrmJtzY4SfxLfpgFidm25/0EQhIfQ6rhq
         1zmT6h+pSHPVHrv2NN/tLHmYN5MgqeqkMryHgwdkgTUq9CRbR7O/QaVBc320Dh1/Peh/
         0+RT7O8GJHv0Vns+JyrN2jQS8avPeJEneLg8oZ18Uw06PBEqCNsT0RLbTyLeJVJq560m
         h1Ac95sLKdJ7fnIbu/BEOjbwlgT4TfsqsPx3mOrmj+hE4X8jDW/m9JiL6E6BitOtRh2h
         vXVg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=LlnJzVxf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c17si10350429pgp.266.2019.08.19.12.33.05;
        Mon, 19 Aug 2019 12:33:20 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=LlnJzVxf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728494AbfHSTcN (ORCPT <rfc822;rajatbajpailinux@gmail.com>
        + 99 others); Mon, 19 Aug 2019 15:32:13 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:7088 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728337AbfHSTcM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Aug 2019 15:32:12 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d5af93b0001>; Mon, 19 Aug 2019 12:32:11 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 19 Aug 2019 12:32:11 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 19 Aug 2019 12:32:11 -0700
Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug
 2019 19:32:11 +0000
Received: from [10.2.161.11] (10.124.1.5) by DRHQMAIL107.nvidia.com
 (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 19 Aug
 2019 19:32:11 +0000
Subject: Re: [Linux-kernel-mentees][PATCH v6 1/2] sgi-gru: Convert put_page()
 to put_user_page*()
To:     Bharath Vedartham <linux.bhar@gmail.com>,
        Dimitri Sivanich <sivanich@hpe.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     <jglisse@redhat.com>, <ira.weiny@intel.com>,
        <gregkh@linuxfoundation.org>, <arnd@arndb.de>,
        <william.kucharski@oracle.com>, <hch@lst.de>,
        <inux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel-mentees@lists.linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>, Michal Hocko <mhocko@kernel.org>
References: <1566157135-9423-1-git-send-email-linux.bhar@gmail.com>
 <1566157135-9423-2-git-send-email-linux.bhar@gmail.com>
 <20190819125611.GA5808@hpe.com>
 <20190819190647.GA6261@bharath12345-Inspiron-5559>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <0c2ad29b-934c-ec30-66c3-b153baf1fba5@nvidia.com>
Date:   Mon, 19 Aug 2019 12:30:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190819190647.GA6261@bharath12345-Inspiron-5559>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 DRHQMAIL107.nvidia.com (10.27.9.16)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1566243131; bh=O1+zBKqCqZBRfmN9e8CVp5s+/FmYKv98YGRf5sf04P8=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=LlnJzVxff7rSopb5VOlbQQEyBfR8LJGnJjJtr6ctEwJXHz9nCk3t12nYZtK9E/pb4
         NPiVaZegJA4RzmJAZfXJa7RTIcCUj2pDko281vNI4rt3to4zQwE5uNlqU2C8OA/CFw
         2m5BK32y9ezYhJqt7xsNZ3NB3m53IN01dDOoJ1C8EMqPKaozA3vv9ATO3gQCSdXrwO
         50OqgKs052g7MMdjIa57lKayaVgPrfP2X8VqXEHSrh9Uqlv6Ek4jDzGP9hX7VTjVRi
         l/yZp/dyHaFYqUcnIeCalSS9LohslZVRzCGaCO+5vOzl8e2mEx1sYpNhTxj9IsuQfr
         DzB8xF6Vdu7zQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/19/19 12:06 PM, Bharath Vedartham wrote:
> On Mon, Aug 19, 2019 at 07:56:11AM -0500, Dimitri Sivanich wrote:
>> Reviewed-by: Dimitri Sivanich <sivanich@hpe.com>
> Thanks!
> 
> John, would you like to take this patch into your miscellaneous
> conversions patch set?
> 

(+Andrew and Michal, so they know where all this is going.)

Sure, although that conversion series [1] is on a brief hold, because
there are additional conversions desired, and the API is still under
discussion. Also, reading between the lines of Michal's response [2]
about it, I think people would prefer that the next revision include
the following, for each conversion site:

Conversion of gup/put_page sites:

Before:

	get_user_pages(...);
	...
	for each page:
		put_page();

After:
	
	gup_flags |= FOLL_PIN; (maybe FOLL_LONGTERM in some cases)
	vaddr_pin_user_pages(...gup_flags...)
	...
	vaddr_unpin_user_pages(); /* which invokes put_user_page() */

Fortunately, it's not harmful for the simpler conversion from put_page()
to put_user_page() to happen first, and in fact those have usually led
to simplifications, paving the way to make it easier to call
vaddr_unpin_user_pages(), once it's ready. (And showing exactly what
to convert, too.)

So for now, I'm going to just build on top of Ira's tree, and once the
vaddr*() API settles down, I'll send out an updated series that attempts
to include the reviews and ACKs so far (I'll have to review them, but
make a note that review or ACK was done for part of the conversion),
and adds the additional gup(FOLL_PIN), and uses vaddr*() wrappers instead of
gup/pup.

[1] https://lore.kernel.org/r/20190807013340.9706-1-jhubbard@nvidia.com

[2] https://lore.kernel.org/r/20190809175210.GR18351@dhcp22.suse.cz


thanks,
-- 
John Hubbard
NVIDIA