Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750975AbVLOTir (ORCPT ); Thu, 15 Dec 2005 14:38:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750973AbVLOTiq (ORCPT ); Thu, 15 Dec 2005 14:38:46 -0500 Received: from smtp.osdl.org ([65.172.181.4]:7114 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750858AbVLOTiq (ORCPT ); Thu, 15 Dec 2005 14:38:46 -0500 Date: Thu, 15 Dec 2005 11:38:19 -0800 (PST) From: Linus Torvalds To: Andrew Morton cc: dhowells@redhat.com, pj@sgi.com, nikita@clusterfs.com, alan@lxorguk.ukuu.org.uk, tglx@linutronix.de, mingo@elte.hu, hch@infradead.org, arjan@infradead.org, matthew@wil.cx, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/19] MUTEX: Introduce simple mutex implementation In-Reply-To: <20051215112115.7c4bfbea.akpm@osdl.org> Message-ID: References: <20051215085602.c98f22ef.pj@sgi.com> <13820.1134558138@warthog.cambridge.redhat.com> <20051213143147.d2a57fb3.pj@sgi.com> <20051213094053.33284360.pj@sgi.com> <20051212161944.3185a3f9.akpm@osdl.org> <20051213075441.GB6765@elte.hu> <20051213090219.GA27857@infradead.org> <20051213093949.GC26097@elte.hu> <20051213100015.GA32194@elte.hu> <6281.1134498864@warthog.cambridge.redhat.com> <14242.1134558772@warthog.cambridge.redhat.com> <16315.1134563707@warthog.cambridge.redhat.com> <1134568731.4275.4.camel@tglx.tec.linutronix.de> <43A0AD54.6050109@rtr.ca> <20051214155432.320f2950.akpm@osdl.org> <17313.29296.170999.539035@gargle.gargle.HOWL> <1134658579.12421.59.camel@localhost.localdomain> <4743.1134662116@warthog.cambridge.redhat.com> <7140.1134667736@warthog.cambridge.redhat.com> <20051215112115.7c4bfbea.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 33 On Thu, 15 Dec 2005, Andrew Morton wrote: > > They should be renamed to DEFINE_* while we're there. A "declaration" is > "this thing is defined somewhere else". A "definition" is "this thing is > defined here". Yeah, I confuse the two. Although by now I've gotten so used to DECLARE_ that at least me personally I like it. > > I wouldn't be adverse to doing that > > argh. Heh. At least there's only 310 DECLARE_MUTEX* references in the whole kernel. So we're not actually talking about a huge patch. It's also fairly simple to work with in out-of-tree drivers, since it's always bound to be a #define, so you can do things like #ifndef DECLARE_SEM_MUTEX #define DECLARE_SEM_MUTEX(x) DECLARE_MUTEX(x) #endif or something. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/