Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3351501ybl; Mon, 19 Aug 2019 17:17:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqy10q7Bg0qGabFk1/9X1mHuwQxMWDvHZV0uKpgryAJ99oItF22QZI8bRRTJrCDLOwt3SZsX X-Received: by 2002:a62:7641:: with SMTP id r62mr26008597pfc.201.1566260221078; Mon, 19 Aug 2019 17:17:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566260221; cv=none; d=google.com; s=arc-20160816; b=ChpYAk3KmHKawULxYo3cYYTjPdsyj7JZ+f1QFvueBmi0aJnZLW2aMNIwxxFsK5XKY3 hOY1c6M8F7YcDs0Np24P9PLUYy1CcYwU6A+/ZImU3xX16npnXVnWBANRaDXYASqh0KsQ N1JxuVwHhXP47j+zZm5hlrX2pe46+4Y2jpVVJZEZof0YdzRgMRvrTD1NFpbOVeswDCyn dfzWG8RTVBJr4+SiFFVx9NIIeP6rbjqZFop4hUaovB3bluQZicnzDtAMnlFjOxtrhXZR 0lpRVENXkum365U6q+9TnqT6g9Oaf7UUvOv6fXVsGFCF3kslst9udO+GIKCT5jSg6AW7 Il/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:organization:references:in-reply-to:date:cc:to:from :subject:message-id; bh=0Q0guuNyzBYr+wKhPD1jDS5yhg/orEWQNlUFhTDsATQ=; b=rH4DHKaiVUWV6C7QEZreok1l610sZ4fGBNRJxaHhqxZK7qWUblN0O6hcctowAegf0+ v8ppHULs9hVYWmLCPHdynNfM94ic4UA3v/IF3EcKL/4UJkNAcS/wKGwROJu0540LNam2 yNArOTuDum0jSD829sQ9L5kc4O6NQWGc6/WoKX872OwziiAgweI5vowt5eWYZZEqaK49 /tNCm94t39JF1B0QY1KIC/zds3ISHJf+LQbfVhUiHNsIROPn3Dyhm4TlaKPUCqa9T/VF TnddjWJJ9RgfoKKDkNgGibptn/olrZ6Qap7REUhCxH1isgTns/BeqY1HVGjis9uY8EZE WSng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r23si10677755pgv.451.2019.08.19.17.16.44; Mon, 19 Aug 2019 17:17:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728727AbfHTAOl (ORCPT + 99 others); Mon, 19 Aug 2019 20:14:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33902 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728578AbfHTAOk (ORCPT ); Mon, 19 Aug 2019 20:14:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 615E6189D6DB; Tue, 20 Aug 2019 00:14:40 +0000 (UTC) Received: from ovpn-117-150.phx2.redhat.com (ovpn-117-150.phx2.redhat.com [10.3.117.150]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF4235D9CD; Tue, 20 Aug 2019 00:14:38 +0000 (UTC) Message-ID: Subject: Re: [RFC v2] rcu/tree: Try to invoke_rcu_core() if in_irq() during unlock From: Scott Wood To: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org Cc: Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , "Paul E. McKenney" , rcu@vger.kernel.org, Steven Rostedt Date: Mon, 19 Aug 2019 19:14:38 -0500 In-Reply-To: <20190818214948.GA134430@google.com> References: <20190818214948.GA134430@google.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Tue, 20 Aug 2019 00:14:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2019-08-18 at 17:49 -0400, Joel Fernandes (Google) wrote: > When we're in hard interrupt context in rcu_read_unlock_special(), we > can still benefit from invoke_rcu_core() doing wake ups of rcuc > threads when the !use_softirq parameter is passed. This is safe > to do so because: What is the benefit, beyond skipping the irq work overhead? Is there some reason to specifically want the rcuc thread woken rather than just getting into the scheduler (and thus rcu_note_context_switch) as soon as possible? -Scott