Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3419878ybl; Mon, 19 Aug 2019 18:38:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3ADTN4s3xSJ3xFrMYe3FVcrzrp3Oi4KZKzQzBRZUV7sZL5FsqH0UlH6ur5rYnVy80wAVD X-Received: by 2002:a17:902:82c4:: with SMTP id u4mr1859296plz.196.1566265105654; Mon, 19 Aug 2019 18:38:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566265105; cv=none; d=google.com; s=arc-20160816; b=GoHui3TA46KVTG98AYYaakgqo5mrfWNJMrKE8HlUC5Ka1pmNUsPOWDPlvuOxmTJ7j0 4sRHN7UmvMlR05VSY7TJdu0r5dlrB5bSXMABMlqts67niIrehs8nk2EeJiff/ive0Bbf 8jBlJaPpnHhbBBvPSr5GAxuHXFs4/x68b+thl58IZRK5/LG9Zvvp7sXJdoK1zJe0Q9Ts je7gUKbNf90SlZAQSLFN3GcrKCp6ICh5f5lK9Zvsza0MG3WeKj3PmyjO1maz3AIOr80l LwP0Ym4z+PocmCf6G0alD4Qv0IReJgiYvq1DF5TYaYoBpqcH4pAa/BsgYPtUQkl1k+Mc FMGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=L2kp3FVACy2bCo+42hdbfxwou/ecopQH0juzHUtX+L4=; b=Sle2x28udS0vF55t3WTXR77Ch23LbJ1GGk18u5wVEucttRyIQBQx+gSA8uK2OzyP56 VlW10sArsU1cMUjFJTPPVQLG76TKffy1xQ9gTKBHJk7voxws8JQfHIO3xL8z5aQoQ9gV MGgwmJWo2dEzgWwpsHmVa8OiEyriiXlXq08DSak6PJ8Odq1Kax1GKoZ+txg34mHwln/l 87SdgTCChBr2TjkmMwbqtKbQ9VqD/zQPthPXJU/TbrtNC2EgN76ZFYE2h/UZ81zPA6oT aL9iz/tsKdUcLesGpuBQ4E6boKP/1K5WAmdHz3KmHrXz6glLU7SITpL/ve6qroUzuQXD 1LnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v24si10912188pgk.509.2019.08.19.18.38.10; Mon, 19 Aug 2019 18:38:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728975AbfHTBfx (ORCPT + 99 others); Mon, 19 Aug 2019 21:35:53 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39376 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728627AbfHTBfx (ORCPT ); Mon, 19 Aug 2019 21:35:53 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DB90E14A872EE; Mon, 19 Aug 2019 18:35:52 -0700 (PDT) Date: Mon, 19 Aug 2019 18:35:52 -0700 (PDT) Message-Id: <20190819.183552.1819321784691078344.davem@davemloft.net> To: marco.hartmann@nxp.com Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, christian.herber@nxp.com Subject: Re: [PATCH net-next 1/1] fec: add C45 MDIO read/write support From: David Miller In-Reply-To: <1566234659-7164-2-git-send-email-marco.hartmann@nxp.com> References: <1566234659-7164-1-git-send-email-marco.hartmann@nxp.com> <1566234659-7164-2-git-send-email-marco.hartmann@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Aug 2019 18:35:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marco Hartmann Date: Mon, 19 Aug 2019 17:11:14 +0000 > @@ -1767,7 +1770,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) > struct fec_enet_private *fep = bus->priv; > struct device *dev = &fep->pdev->dev; > unsigned long time_left; > - int ret = 0; > + int ret = 0, frame_start, frame_addr, frame_op; > Please retain the reverse christmas tree ordering of local variables here, thank you.