Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3453269ybl; Mon, 19 Aug 2019 19:24:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxk1E29owam0GqUHcHKqP87yLHObj5mqbOBRkmuqBr/H6GgilsAbzOT9ZOEfpBWslfpWqxh X-Received: by 2002:a17:902:a586:: with SMTP id az6mr24098889plb.298.1566267897379; Mon, 19 Aug 2019 19:24:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566267897; cv=none; d=google.com; s=arc-20160816; b=tn0YlhLiYhLPGkP4uoWHMG9Wb3WffWEZghyumaywx7/txR/WeQ0bKFYCHlZglyI261 2CQLvQKswm0YL1iikBLnohBd7znOD726IFztaxd3mNIeebyy0yvetTdsanE81e1udgkD stKcEx8vvb7HfvDYeQSQjeQXCFyg/aJ/sj3qeyUrz+9W9fF98NTRNh846h6TRBbvXIKn m0aTnU/u+T1Kk26/yeoyTg0pmson+k5+cT/0aUf1u7bLTPwmwceMfCHUyacR0QFF0Un1 mwIJwTRTMrc/5d+HNMDxxeu3RMyN8fXZZOJFNLnARL/KgDrZhImWr4vREWPd8tRxzB6H jfVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=iUfbQEUhfcGsCefDomyNE5fPkfexhgH+opkgX3KS754=; b=HnKqv89x/zWdYUg4iOmBsiz1NBiHWz4kwe1gRJnAPHNHTdXEexZpg2BeLzyazAQG5B K9QdYhreGu772YxkkJUiEP6AC2KIPzAEsR37x2x4vlHawWUMnTNNdnzKV8eZgKDIk1r3 l2R3g0wxQnJaQxbTXvNVR+vzVzxkETXQkDOcdf75RVXPEsmsly9YJQ/XcFQhhWuNCAGw rHi517yxM+qGb0vCwO8ljCwThpp5knGU703kZWa7jeUqv0PMziz7frQ1JsWBQWUed8YZ Wug61p5yaY4Tdh2/lHPLpLm9rUO/9ay0EUDDECHfKHFf189NcPgWnSLog460Cf3P3sUa 9iGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=h+aHcx+Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c15si11066878pgi.273.2019.08.19.19.24.42; Mon, 19 Aug 2019 19:24:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=h+aHcx+Y; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbfHTCWh (ORCPT + 99 others); Mon, 19 Aug 2019 22:22:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50006 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728615AbfHTCWh (ORCPT ); Mon, 19 Aug 2019 22:22:37 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7K2JOrh156561; Tue, 20 Aug 2019 02:22:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=iUfbQEUhfcGsCefDomyNE5fPkfexhgH+opkgX3KS754=; b=h+aHcx+Y4lOd799WOKU346Sklcl9G4t4pSSu2QSYWfid8kd8x0L5K5M3/d1boXLLDyBZ rD+IjoBq++ys01K4BilHMFFsKlg56KzuA93cjAdP2UBgzCZn0KMP0SqPGWIXotEk86Ln yd6BhqV445ixRzlVodG5kRocKdTL9MychOFyca6xYzATM+bJbW82Egd82hXpx3KUfxZG nKIw/ElE6j8Vf9vhKTtRjTbP7tN/Av41nHf3sXZ9ShNKOfH+I+1enGuJUU2TGzKqwrch uKHygshFrS7vE8HtnpkrgfUwb/+6+WkWoE4Yijp42GINbol3N8QHu8Ph2KMLPHYrE5EQ TA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2uea7qjyef-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Aug 2019 02:22:31 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7K2IVdn172710; Tue, 20 Aug 2019 02:22:31 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2ug2681u71-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Aug 2019 02:22:31 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7K2MTkP011271; Tue, 20 Aug 2019 02:22:29 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 19 Aug 2019 19:22:28 -0700 To: Hariprasad Kelam Cc: James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: lpfc: fix "NULL check before some freeing functions is not needed" From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190721114229.GA6886@hari-Inspiron-1545> Date: Mon, 19 Aug 2019 22:22:26 -0400 In-Reply-To: <20190721114229.GA6886@hari-Inspiron-1545> (Hariprasad Kelam's message of "Sun, 21 Jul 2019 17:12:29 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9354 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=730 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908200019 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9354 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=808 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908200019 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hariprasad, > As dma_pool_destroy and mempool_destroy functions has NULL check. We may > not need NULL check before calling them. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering