Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3455818ybl; Mon, 19 Aug 2019 19:28:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxHn5HjswYyDI7AXTRYQPCzT40zzW3toLx7CBNIwR2ZNyxArMlKuqBj38g433a/HxfyUQzE X-Received: by 2002:a63:a66:: with SMTP id z38mr23302705pgk.247.1566268120712; Mon, 19 Aug 2019 19:28:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566268120; cv=none; d=google.com; s=arc-20160816; b=aVUGaXVMirv2IS0uZ/zCt5nEl/BnvPHnm/xImgcC7Ekomp1/+r0vjI6rm2dcx2rP4E JiJ/ukhRLnMs30u9eU0x0XwSa4Z/RROXabkGfn9rfzuzAbgUd1CI8cCDZ8s6Ir5cV/0D KDDzHBYCf1gHXvRTka7gpDFnZPC+SV8nL/4jeEGfmy/JsnlKczh0f3GJqNZ/KuS256fP XvU1MSKlSmButFZOunSRBxWtxeDeUv9Wpr/F70690aRFnxxUYEjsr00GskumxQZ7/WLN 17MUYeGn7x5rUcG94P9rDFGXLUVkZau77EfBAZSbbhbHKOTclG7rNjf0EwyNyhN6hnsV jFJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=t72HVa1CX6glbFJNyQkOUEyJ5qPX1giRA8xMQo91sb4=; b=HPoJhgOPn+LkAyG7F0kyd3SarKIC/nZz0cJgx1UcoWOC0ddw22M1CkkAfuwTK2t3yK OQSOGYvCYO5YHcAn7Ewh7XjMm75XAR+rYIsw9wTCgx8r9zgC9k6EiuCmRJYFBJjGjFMX S6pr4sJ6G4oFquaz2RTXpn87A6Rklq1BmgzocVwzUGATemjQuBj3RNSkEEBvP3Co6t37 LiC/uC+mp3LPeB+yF2foGe3p+/N53au3W10HYEalGdstRPh1C8BiK5h8aJSoOgVRDAvT rA4yhnPO3x58LRmwdgwX3u2Cq3pDyLymneQtwtlI7Ixisbzp1oaUzgXb7xZQ0yPn8tSV r5Mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u2si10955836pgr.284.2019.08.19.19.28.25; Mon, 19 Aug 2019 19:28:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729002AbfHTC0X (ORCPT + 99 others); Mon, 19 Aug 2019 22:26:23 -0400 Received: from verein.lst.de ([213.95.11.211]:52591 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728878AbfHTC0X (ORCPT ); Mon, 19 Aug 2019 22:26:23 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9B59668B02; Tue, 20 Aug 2019 04:26:19 +0200 (CEST) Date: Tue, 20 Aug 2019 04:26:19 +0200 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Jason Gunthorpe , Bharata B Rao , Andrew Morton , Linux MM , Linux Kernel Mailing List , linux-nvdimm , Ira Weiny Subject: Re: [PATCH 1/4] resource: add a not device managed request_free_mem_region variant Message-ID: <20190820022619.GA23225@lst.de> References: <20190818090557.17853-1-hch@lst.de> <20190818090557.17853-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 19, 2019 at 06:28:30PM -0700, Dan Williams wrote: > > Previously we would loudly crash if someone passed NULL to > devm_request_free_mem_region(), but now it will silently work and the > result will leak. Perhaps this wants a: We'd still instantly crash due to the dev_name dereference, right?