Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1563154124-18579-1-git-send-email-wanpengli@tencent.com> <ba3ae595-7f82-d17b-e8ed-6e86e9195ce5@redhat.com>
In-Reply-To: <ba3ae595-7f82-d17b-e8ed-6e86e9195ce5@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Tue, 20 Aug 2019 15:16:07 +0800
Message-ID: <CANRm+Cx1bEOXBx50K9gv08UWEGadKOCtCbAwVo0CFC-g1gS+Xg@mail.gmail.com>
Subject: Re: [PATCH RESEND] i386/kvm: support guest access CORE cstate
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Eduardo Habkost <ehabkost@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Kindly reminder, :)
On Mon, 15 Jul 2019 at 17:16, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 15/07/19 03:28, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > Allow guest reads CORE cstate when exposing host CPU power management c=
apabilities
> > to the guest. PKG cstate is restricted to avoid a guest to get the whol=
e package
> > information in multi-tenant scenario.
> >
> > Cc: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> > Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>
> Hi,
>
> QEMU is in hard freeze now.  This will be applied after the release.
>
> Thanks,
>
> Paolo
>
> > ---
> >  linux-headers/linux/kvm.h | 4 +++-
> >  target/i386/kvm.c         | 3 ++-
> >  2 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> > index b53ee59..d648fde 100644
> > --- a/linux-headers/linux/kvm.h
> > +++ b/linux-headers/linux/kvm.h
> > @@ -696,9 +696,11 @@ struct kvm_ioeventfd {
> >  #define KVM_X86_DISABLE_EXITS_MWAIT          (1 << 0)
> >  #define KVM_X86_DISABLE_EXITS_HLT            (1 << 1)
> >  #define KVM_X86_DISABLE_EXITS_PAUSE          (1 << 2)
> > +#define KVM_X86_DISABLE_EXITS_CSTATE         (1 << 3)
> >  #define KVM_X86_DISABLE_VALID_EXITS          (KVM_X86_DISABLE_EXITS_MW=
AIT | \
> >                                                KVM_X86_DISABLE_EXITS_HL=
T | \
> > -                                              KVM_X86_DISABLE_EXITS_PA=
USE)
> > +                                              KVM_X86_DISABLE_EXITS_PA=
USE | \
> > +                                              KVM_X86_DISABLE_EXITS_CS=
TATE)
> >
> >  /* for KVM_ENABLE_CAP */
> >  struct kvm_enable_cap {
> > diff --git a/target/i386/kvm.c b/target/i386/kvm.c
> > index 3b29ce5..49a0cc1 100644
> > --- a/target/i386/kvm.c
> > +++ b/target/i386/kvm.c
> > @@ -1645,7 +1645,8 @@ int kvm_arch_init(MachineState *ms, KVMState *s)
> >          if (disable_exits) {
> >              disable_exits &=3D (KVM_X86_DISABLE_EXITS_MWAIT |
> >                                KVM_X86_DISABLE_EXITS_HLT |
> > -                              KVM_X86_DISABLE_EXITS_PAUSE);
> > +                              KVM_X86_DISABLE_EXITS_PAUSE |
> > +                              KVM_X86_DISABLE_EXITS_CSTATE);
> >          }
> >
> >          ret =3D kvm_vm_enable_cap(s, KVM_CAP_X86_DISABLE_EXITS, 0,
> >
>