Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH]Perf: Return error code for perf_session__new function on
 failure
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     linux-kernel@vger.kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        namhyung@kernel.org, kstewart@linuxfoundation.org,
        gregkh@linuxfoundation.org, jeremie.galarneau@efficios.com,
        shawn@git.icu, tstoyanov@vmware.com, tglx@linutronix.de,
        alexey.budankov@linux.intel.com, adrian.hunter@intel.com,
        songliubraving@fb.com, ravi.bangoria@linux.ibm.com
References: <20190814092654.7781.81601.stgit@localhost.localdomain>
 <20190815125116.GG30356@krava>
From:   Mamatha Inamdar <mamatha4@linux.vnet.ibm.com>
Date:   Tue, 20 Aug 2019 14:09:04 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190815125116.GG30356@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Message-Id: <aab6e549-38b3-b18a-003c-9d1d96d7617c@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jiri Olsa,

Thanks for reviewing the patch..

working on your comments, will post new version ASAP.


On 15/08/19 6:21 PM, Jiri Olsa wrote:
> On Wed, Aug 14, 2019 at 03:02:18PM +0530, Mamatha Inamdar wrote:
>
> SNIP
>
>>   		symbol_conf.pid_list_str = strdup(trace->opts.target.pid);
>> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
>> index ddbcd59..dbc6dc2 100644
>> --- a/tools/perf/util/data-convert-bt.c
>> +++ b/tools/perf/util/data-convert-bt.c
>> @@ -1619,8 +1619,10 @@ int bt_convert__perf2ctf(const char *input, const char *path,
>>   	err = -1;
>>   	/* perf.data session */
>>   	session = perf_session__new(&data, 0, &c.tool);
>> -	if (!session)
>> +	if (IS_ERR(session)) {
>> +		err = PTR_ERR(session);
>>   		goto free_writer;
>> +	}
>>   
>>   	if (c.queue_size) {
>>   		ordered_events__set_alloc_size(&session->ordered_events,
> I'm getting:
>
>    CC       util/data-convert-bt.o
> util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
> util/data-convert-bt.c:1622:6: error: implicit declaration of function ‘IS_ERR’; did you mean ‘SIG_ERR’? [-Werror=implicit-function-declaration]
>   1622 |  if (IS_ERR(session)) {
>        |      ^~~~~~
>        |      SIG_ERR
> util/data-convert-bt.c:1622:6: error: nested extern declaration of ‘IS_ERR’ [-Werror=nested-externs]
> util/data-convert-bt.c:1623:9: error: implicit declaration of function ‘PTR_ERR’ [-Werror=implicit-function-declaration]
>   1623 |   err = PTR_ERR(session);
>
>
> jirka
>