Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3771107ybl; Tue, 20 Aug 2019 01:55:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNIiTClr92AUiO/olc0IaOnUBv/UdDCNjlt3viZ8+3XETHBPkUCwQCPGReMsvp8EYJGkyz X-Received: by 2002:aa7:9ab8:: with SMTP id x24mr28184299pfi.98.1566291321667; Tue, 20 Aug 2019 01:55:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566291321; cv=none; d=google.com; s=arc-20160816; b=NgdWm8OIK1IBfTuGXIl01tH+M6A+Gmfd7UvHlq2kwhTrP6RtRYyct11jgRLExFycEe HtkUWRwoRdIylt1Dpl4TNLXSf51NhFaB9s633UW/MCfD6SowQcBuA2CwTL8oNDovyFz6 pRhJTf4jtpl7HyUQWANYcti7efEBEzVuGfGNnLLiNW2YRDwhxSNHlfOIr4S2GFhaZFwZ szyvM+XiQyp/Vs0H1K9DvPaUw3HvkP1TMcscq7Qgaxbm8+IqLyoBbge/D/cjY4CCGFrw U8tarsKhvPhwqFL0I+LtIYjzXujDoK5B51/2Kiz4xrEre3Y2jI3itFj/YK0nIjMG2txf h9rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=AHp9FMDFPAEibb/c4TraeSpK/4n8ox8ZSkZxMZhxBao=; b=DwG1JfgkIAOoGeEwrmGr+kIQEUghuzVgz0qOcCfK/aAwvuFYWBzA3wByeH4JvxoxLN FfQRkoidkk9CfwVEzyepDOczkzagSL0y3u/5kPVuPL6Zbjd9LSHFRKitX4yxpZ8vbt1j 5pxRDSEcca5mkeIAA4mBTBHQRZel44bTIgPro1rGNihkYV7paV/yToO5a+PalPJN/o5M Ba6WfUwYSVYC0q2fiZGIKWhBABTGDzwXHADpsRZWjK1ASDmJOYbKXmxEZASlWDjAC2mC Rrp7D0AwZ6wgWF0zyPBxwv8hV3qHg14leCuowE5+skmMvoNLhCPEtP0IKDPAOrx6vf+M N/Ig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o132si12405305pfg.249.2019.08.20.01.55.06; Tue, 20 Aug 2019 01:55:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729522AbfHTIyN (ORCPT + 99 others); Tue, 20 Aug 2019 04:54:13 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:51162 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729342AbfHTIyL (ORCPT ); Tue, 20 Aug 2019 04:54:11 -0400 Received: from p5de0b6c5.dip0.t-ipconnect.de ([93.224.182.197] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hzztv-0007fA-Do; Tue, 20 Aug 2019 10:53:59 +0200 Date: Tue, 20 Aug 2019 10:53:58 +0200 (CEST) From: Thomas Gleixner To: Jisheng Zhang cc: Catalin Marinas , Jonathan Corbet , Will Deacon , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "x86@kernel.org" , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v2 1/3] kprobes/x86: use instruction_pointer and instruction_pointer_set In-Reply-To: <20190820114109.4624d56b@xhacker.debian> Message-ID: References: <20190820113928.1971900c@xhacker.debian> <20190820114109.4624d56b@xhacker.debian> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Aug 2019, Jisheng Zhang wrote: > This is to make the x86 kprobe_ftrace_handler() more common so that > the code could be reused in future. While I agree with the change in general, I can't find anything which reuses that code. So the change log is pretty useless and I have no idea how this is related to the rest of the series. Thanks, tglx