Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 20 Aug 2019 18:59:18 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To:     John Ogness <john.ogness@linutronix.de>
Cc:     linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andrea Parri <andrea.parri@amarulasolutions.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [RFC PATCH v4 8/9] printk-rb: new functionality to support printk
Message-ID: <20190820095918.GB14137@jagdpanzerIV>
References: <20190807222634.1723-1-john.ogness@linutronix.de>
 <20190807222634.1723-9-john.ogness@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190807222634.1723-9-john.ogness@linutronix.de>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On (08/08/19 00:32), John Ogness wrote:
[..]
> +void prb_init(struct printk_ringbuffer *rb, char *data, int data_size_bits,
> +	      struct prb_desc *descs, int desc_count_bits,
> +	      struct wait_queue_head *waitq)
> +{
> +	struct dataring *dr = &rb->dr;
> +	struct numlist *nl = &rb->nl;
> +
> +	rb->desc_count_bits = desc_count_bits;
> +	rb->descs = descs;
> +	atomic_long_set(&descs[0].id, 0);
> +	descs[0].desc.begin_lpos = 1;
> +	descs[0].desc.next_lpos = 1;

dataring_desc_init(), perhaps?

> +	atomic_set(&rb->desc_next_unused, 1);
> +
> +	atomic_long_set(&nl->head_id, 0);
> +	atomic_long_set(&nl->tail_id, 0);
> +	nl->node = prb_desc_node;
> +	nl->node_arg = rb;
> +	nl->busy = prb_desc_busy;
> +	nl->busy_arg = rb;
> +
> +	dr->size_bits = data_size_bits;
> +	dr->data = data;
> +	atomic_long_set(&dr->head_lpos, -111 * sizeof(long));
> +	atomic_long_set(&dr->tail_lpos, -111 * sizeof(long));
> +	dr->getdesc = prb_getdesc;
> +	dr->getdesc_arg = rb;
> +
> +	atomic_long_set(&rb->fail, 0);
> +
> +	rb->wq = waitq;
> +}
> +EXPORT_SYMBOL(prb_init);

	-ss