Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3878950ybl; Tue, 20 Aug 2019 03:46:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9XsAjCfcWV17yhmOHY3AYT0/jIzUePmHjF0i0KznEzgWylpSConeLsbGXupMwlA7bb2ph X-Received: by 2002:a17:90a:f0c9:: with SMTP id fa9mr24669604pjb.137.1566297998589; Tue, 20 Aug 2019 03:46:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566297998; cv=none; d=google.com; s=arc-20160816; b=zffSecNGkPL79yqgl/eAh9FdDXkBw92f/uJk+82W5MGFWQHxRFhizOYxDehPVIiE51 IDxz0GKmfHkcff3IkQnkKhYQe4UwtvWWXQYEAVThbQawewYbSYcdODOXCpDH7fsja0YM pKBKrLMspQkBO2kJA5NFCBxVmtnYY19J6V1Pi21Z5A2Pvo3bxx9ZTlHSnMcpRnKR1UFn SO/ggpBs8MGawAjB6wvaxefFrGW7BrFV1PXpPdvcucuh8zI/mVbj608GuETKUIxm0eGC 6RiNGSorzyWZUEY3cHw0OJfK8Oq36FktFTB8w5GRinXiLUb4wS3U+qP+HNkECMwPDx2D ZO0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CjFk1oqK14dYfFFS9W+ZhHO4FY+sr/1iQCGVtkJfteE=; b=sAk/QV6hIh8PA7yJ8yVbF58Dt3iZOR6fQCFWFUKq3rB8efQUiFKjpuEsHNUIWNyXF6 2ESXzdOzQ5ADUPGJEoyi7JRRBMdhHjhN9VfC9ias4ij1ydq+Ny9k+H+0hNDtvHuMMAqB bVrwbExWl0YAWw0mh8PMUPVZlWpviunotP+qrXX0CEjp8eF/ItUfua3W0gKcyf48emCZ MV88DfzaTmd8NIHk4hTB10YPy6ZyCoDj4vjvPD3+3tgys7AP7Yzuv23itCdQe5uow1RL qjvj1MlU6TmisyeKz7M199VqvuucNU+gNnU59hi/Ruq1DXo49PfvQy5xw38izsSTwPEN dfGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13si11864820pgq.317.2019.08.20.03.46.23; Tue, 20 Aug 2019 03:46:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729560AbfHTKpf (ORCPT + 99 others); Tue, 20 Aug 2019 06:45:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:38624 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728414AbfHTKpe (ORCPT ); Tue, 20 Aug 2019 06:45:34 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 69F2AADD9; Tue, 20 Aug 2019 10:45:33 +0000 (UTC) Date: Tue, 20 Aug 2019 12:45:32 +0200 From: Michal Hocko To: Alex Shi Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins Subject: Re: [PATCH 00/14] per memcg lru_lock Message-ID: <20190820104532.GP3111@dhcp22.suse.cz> References: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1566294517-86418-1-git-send-email-alex.shi@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 20-08-19 17:48:23, Alex Shi wrote: > This patchset move lru_lock into lruvec, give a lru_lock for each of > lruvec, thus bring a lru_lock for each of memcg. > > Per memcg lru_lock would ease the lru_lock contention a lot in > this patch series. > > In some data center, containers are used widely to deploy different kind > of services, then multiple memcgs share per node pgdat->lru_lock which > cause heavy lock contentions when doing lru operation. Having some real world workloads numbers would be more than useful for a non trivial change like this. I believe googlers have tried something like this in the past but then didn't have really a good example of workloads that benefit. I might misremember though. Cc Hugh. -- Michal Hocko SUSE Labs