Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp3942464ybl; Tue, 20 Aug 2019 04:47:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBQ6UrhKynJO5g7UbdkRikJZltOlPocfImx0prJsgljl4lyqgDCven5nocmePqtR2oYcnD X-Received: by 2002:a17:90a:bc4b:: with SMTP id t11mr26284371pjv.87.1566301631222; Tue, 20 Aug 2019 04:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566301631; cv=none; d=google.com; s=arc-20160816; b=boktYxtREu/lYBRZkcHDtwJfDA7JV2mx9EuApVh81QWkXAUO1D79HBLFvunahzbTtd U4zusjawNNq7pNbrS4vUBfJNvimYlawfyM8ieDx/0fkniCyqkUaBYwWxfcg2Mx2j5xv/ Ss2g1kr2DJwP31Fy4PjKFUQW/QjciFmQW7mNOcwpZGcl87NB09oM6+vydxfU9WwFObzp Jfm+Dzwypmrd87dCuk5jWbb75J/l14lOPFHBSsuNCQkyCvridhOwmx60WxYDBLFvjxiJ xBurvW5X+k1nWMKcFD5LmjoH3Jm2tjeadWstSA5DZlZ8Fna3mt2WArkwOKQcrZgIycwQ XwDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WJ/Ah7B3BJO7UCh8qmkKFdvonpGAGsnHJEYoi0lFzu8=; b=kgpVeA0ITn29pfqE9XqychIlxNKXoz79bZJpnnLhGngIE0YenjCWpg2lQff+eu2cmS UWCUPxTbDQwRSDHwWm69QnXGGkemzSen6Ca+qXJrAuZ/XroJy+zf06iNqa12FLJ9gEne b7wadQQhZ2jNUMuv4lObQ1sMId+mEkHcbAlCH1UQbc5FAh6EoZgs/kDYbxSY3+ZzCk3i iXv1vDti8RQMjI39mpee4BroZRluAsHDdrBSkeiG2yDdrzMpcRnutL+q2mZzGcf0nkCp DR76f12p/D75Ogn7URJfcxuNk/b+/9XLTKGtl9g/b3WcZiAmXWicy32NRWgZleGm93km 0ppw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fDMllfag; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x14si11060185pjf.45.2019.08.20.04.46.55; Tue, 20 Aug 2019 04:47:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fDMllfag; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729826AbfHTLpR (ORCPT + 99 others); Tue, 20 Aug 2019 07:45:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:47126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729574AbfHTLpR (ORCPT ); Tue, 20 Aug 2019 07:45:17 -0400 Received: from localhost (unknown [106.201.62.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CD5C22CE3; Tue, 20 Aug 2019 11:45:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566301516; bh=0lT4v0LX5pXjxpd6d87L+ufuAZo4ezWjtwt8ULNdJPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDMllfagwKR8/yMdUxTCr+elQziywK4erQs3BAm7X1MV4qGn5c4YYxwVNB79ZxSt1 fGQxFMaJMOKTxT3jVgRlowh/ueYII+COBETOpzG2HRuXis4+qF3TSeRHI/juwti0jp Bxoiih4+OKFKAyQnhv7Jl7N5tu0KkSjElIyPf/ac= Date: Tue, 20 Aug 2019 17:14:05 +0530 From: Vinod Koul To: Wenwen Wang Cc: Dan Williams , Enrico Weigelt , Allison Randal , Kate Stewart , Greg Kroah-Hartman , Thomas Gleixner , "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , open list Subject: Re: [PATCH] dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe() Message-ID: <20190820114405.GY12733@vkoul-mobl.Dlink> References: <1565938570-7528-1-git-send-email-wenwen@cs.uga.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565938570-7528-1-git-send-email-wenwen@cs.uga.edu> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16-08-19, 01:56, Wenwen Wang wrote: > If devm_request_irq() fails to disable all interrupts, no cleanup is > performed before retuning the error. To fix this issue, invoke > omap_dma_free() to do the cleanup. Applied, thanks -- ~Vinod