Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] uacce: add uacce module
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, linux-accelerators@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, Kenneth Lee <liguozhu@hisilicon.com>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Zhou Wang <wangzhou1@hisilicon.com>
References: <1565775265-21212-1-git-send-email-zhangfei.gao@linaro.org>
 <1565775265-21212-3-git-send-email-zhangfei.gao@linaro.org>
 <20190815142021.GE23267@kroah.com>
 <5d5a6f5b.1c69fb81.9d35e.5303SMTPIN_ADDED_BROKEN@mx.google.com>
 <20190819102413.GB2030@kroah.com>
From:   zhangfei <zhangfei.gao@linaro.org>
Message-ID: <0f7c6241-2028-76e7-0314-8b99cd353bd6@linaro.org>
Date:   Tue, 20 Aug 2019 20:36:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190819102413.GB2030@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Greg

On 2019/8/19 下午6:24, Greg Kroah-Hartman wrote:
>>>> +static int uacce_create_chrdev(struct uacce *uacce)
>>>> +{
>>>> +	int ret;
>>>> +
>>>> +	ret = idr_alloc(&uacce_idr, uacce, 0, 0, GFP_KERNEL);
>>>> +	if (ret < 0)
>>>> +		return ret;
>>>> +
>>> Shouldn't this function create the memory needed for this structure?
>>> You are relying ont he caller to do it for you, why?
>> I think you mean uacce structure here.
>> Yes, currently we count on caller to prepare uacce structure and call
>> uacce_register(uacce).
>> We still think this method is simpler, prepare uacce, register uacce.
>> And there are other system using the same method, like crypto
>> (crypto_register_acomp), nand, etc.
> crypto is not a subsystem to ever try to emulate :)
>
> You are creating a structure with a lifetime that you control, don't
> have someone else create your memory, that's almost never what you want
> to do.  Most all driver subsystems create their own memory chunks for
> what they need to do, it's a much better pattern.
>
> Especially when you get into pointer lifetime issues...
OK, understand now, thanks for your patience.
will use this instead.
struct uacce_interface {
         char name[32];
         unsigned int flags;
         struct uacce_ops *ops;
};
struct uacce *uacce_register(struct device *dev, struct uacce_interface 
*interface);
>>>> +}
>>>> +
>>>> +static int uacce_dev_match(struct device *dev, void *data)
>>>> +{
>>>> +	if (dev->parent == data)
>>>> +		return -EBUSY;
>>> There should be in-kernel functions for this now, no need for you to
>>> roll your own.
>> Sorry, do not find this function.
>> Only find class_find_device, which still require match.
> It is in linux-next, look there...
>
Suppose you mean the funcs: device_match_name, 
device_match_of_node,device_match_devt etc.
Here we need dev->parent, there still no such func.

Thanks