Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 20 Aug 2019 07:31:35 -0700
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     zhangfei <zhangfei.gao@linaro.org>
Cc:     "zhangfei.gao@foxmail.com" <zhangfei.gao@foxmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Kenneth Lee <liguozhu@hisilicon.com>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Zhou Wang <wangzhou1@hisilicon.com>
Subject: Re: [PATCH 2/2] uacce: add uacce module
Message-ID: <20190820143135.GA1536@kroah.com>
References: <1565775265-21212-1-git-send-email-zhangfei.gao@linaro.org>
 <1565775265-21212-3-git-send-email-zhangfei.gao@linaro.org>
 <20190815141225.GC23267@kroah.com>
 <5d5a6757.1c69fb81.e0678.2ab2SMTPIN_ADDED_BROKEN@mx.google.com>
 <20190819102250.GA2030@kroah.com>
 <350c937f-faee-f74a-ad76-03532c8648bd@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <350c937f-faee-f74a-ad76-03532c8648bd@linaro.org>
User-Agent: Mutt/1.12.1 (2019-06-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Aug 20, 2019 at 08:38:46PM +0800, zhangfei wrote:
> 
> 
> On 2019/8/19 下午6:22, Greg Kroah-Hartman wrote:
> > On Mon, Aug 19, 2019 at 05:09:23PM +0800, zhangfei.gao@foxmail.com wrote:
> > > Hi, Greg
> > > 
> > > Thanks for your kind suggestion.
> > > 
> > > On 2019/8/15 下午10:12, Greg Kroah-Hartman wrote:
> > > > On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote:
> > > > > diff --git a/include/uapi/misc/uacce.h b/include/uapi/misc/uacce.h
> > > > > new file mode 100644
> > > > > index 0000000..44a0a5d
> > > > > --- /dev/null
> > > > > +++ b/include/uapi/misc/uacce.h
> > > > > @@ -0,0 +1,44 @@
> > > > > +/* SPDX-License-Identifier: GPL-2.0-or-later */
> > > > > +#ifndef _UAPIUUACCE_H
> > > > > +#define _UAPIUUACCE_H
> > > > > +
> > > > > +#include <linux/types.h>
> > > > > +#include <linux/ioctl.h>
> > > > > +
> > > > > +#define UACCE_CLASS_NAME	"uacce"
> > > > Why is this in a uapi file?
> > > User app need get attribute from /sys/class,
> > > For example: /sys/class/uacce/hisi_zip-0/xxx
> > > UACCE_CLASS_NAME here tells app which subsystem to open,
> > > /sys/class/subsystem/
> > But that never comes from a uapi file.  No other subsystem does this.
> OK, got it
> Maybe the entry info can come from Documentation/ABI/entries

Yes it can, we now have a tool in the tree that automatically parses
those entries and outputs it in a variety of different formats.

thanks,

greg k-h