Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4184789ybl; Tue, 20 Aug 2019 08:10:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKcdVooRiDeGXU6yAXxZ3fL76rHe1NhVbqFy8COYusjCyKiJEfh2Cu4P4bJMZoJbVUnZ9n X-Received: by 2002:a17:902:4ac2:: with SMTP id q2mr26337094plh.81.1566313810161; Tue, 20 Aug 2019 08:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566313810; cv=none; d=google.com; s=arc-20160816; b=aKpx/PzHXaSYBDMRD9l/4uZZqJuI602B91UG0Hdnj7YWc+hvtPMpyEl9AJYlRtvzL3 E6Bz42zXEU/RHb8zeOdN8C2tChJYixC9yImr5uuJj/n1/FhUGeTCMaO6nXD7rw9pnBlb wxAT23SzLlqqFkoN8xzyS8mmQwRl85/f9/jXgJSWbjYd5DqwdDQYCn3mg8zTDaPc4kGr 1ADgF6vAU5FMvcb8cGxDuc99VO7S1ixiN5bw5j9IzTvITDDYGWds7AE9CzBq8Q6PqgGM gykddz5TZyo6HbPT53O/rup1kTmLvZE094cVeOqhmSe26prEipSJB1fhGqYmxs4CtxOU cMCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=fkm0Gnbslr5C0vq+7xWrCFqFdHpTtKB9TVv2Fp4j72s=; b=Rdc2HrhMBLBtjmUnjMz8yGWa1/nQaESqWiyKMMwa5y1zerqqoOKvgVsPNsReAX24vH CUGWRzNK8Grd9z2KdWe0btOqjZi+40JiH8ShxzlRUPaPcV2u/qNmjUxTyniufiaabaEA hZ/zz/fDBeWHYgdgAraiVz4RMntAgx+5PPA8hqHDxgCG5DJAfWo5NNN8J0pK0QAW0R4A KQrNybiD/l05pp5iCgZFbV3Y1XnEk24OFh248XG/fkw5G9myWZgcqamDjG5/SK1vhL8h lFGE3drep/573Fx01I9LQzU1Oat6+Iy7INgoPeL2iVcFgisJvrjFrcoidtxOxuzbs8CP t0Lg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 124si12105368pgg.581.2019.08.20.08.09.53; Tue, 20 Aug 2019 08:10:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730190AbfHTPHO (ORCPT + 99 others); Tue, 20 Aug 2019 11:07:14 -0400 Received: from mga05.intel.com ([192.55.52.43]:57119 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726879AbfHTPHO (ORCPT ); Tue, 20 Aug 2019 11:07:14 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Aug 2019 08:07:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,408,1559545200"; d="scan'208";a="183225260" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga006.jf.intel.com with ESMTP; 20 Aug 2019 08:07:12 -0700 Date: Tue, 20 Aug 2019 09:05:11 -0600 From: Keith Busch To: John Garry Cc: Ming Lei , "longli@linuxonhyperv.com" , Ingo Molnar , Peter Zijlstra , "Busch, Keith" , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme , Linux Kernel Mailing List , Long Li , Thomas Gleixner , chenxiang Subject: Re: [PATCH 0/3] fix interrupt swamp in NVMe Message-ID: <20190820150511.GD11202@localhost.localdomain> References: <1566281669-48212-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 20, 2019 at 01:59:32AM -0700, John Garry wrote: > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index e8f7f179bf77..cb483a055512 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -966,9 +966,13 @@ irq_thread_check_affinity(struct irq_desc *desc, > struct irqaction *action) > * mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out. > */ > if (cpumask_available(desc->irq_common_data.affinity)) { > + struct irq_data *irq_data = &desc->irq_data; > const struct cpumask *m; > > - m = irq_data_get_effective_affinity_mask(&desc->irq_data); > + if (action->flags & IRQF_IRQ_AFFINITY) > + m = desc->irq_common_data.affinity; > + else > + m = irq_data_get_effective_affinity_mask(irq_data); > cpumask_copy(mask, m); > } else { > valid = false; > -- > 2.17.1 > > As Ming mentioned in that same thread, we could even make this policy > for managed interrupts. Ack, I really like this option!