Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4216177ybl; Tue, 20 Aug 2019 08:36:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxTJi55S5sEURkrEFHG5s2w0Na65a7VwfPZT+DSEiq9/7BnWjhsunax6m15C/AlzT6zxUM X-Received: by 2002:a62:d0:: with SMTP id 199mr30538050pfa.157.1566315384788; Tue, 20 Aug 2019 08:36:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566315384; cv=none; d=google.com; s=arc-20160816; b=JyoixdPv6ZYiouzUu1StM1xAWjVm9R1Le9f1V1gpk9QTV1MXoPWUG5N5INcOm6fw8/ ssjfSxb57yT2QZ1E9rKjOqRxaKZapJuj4aRAUXdH/h0nszeI/6pee8zT/Zp4SviMgeiU bw/9NixiCo0rSMKxUEbviKSqSIfwLU/5sfKbCqWW2wrGe/pJRF+o73lPCzbrJL9H3BpA PXCPL/6AKnBQ1eDy+NR45OPfpoNbeu+BBN5S9daKpU7XAfLl4p7C8jIxO/vFtHXuFL5C jimEvOENhnPZJxeN87OtpV9dDbxpTI2ITBJ1Qtv9H6+ScMHBTPSMOLW43+ve6maSiM7Z ZwHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=N2+2l4A/E+OsKIUB6+AmwoJhA8cvomoHnElAOLekhLE=; b=CBvRw3eNX8Vj5Yd299flivP7PKyJetD6Zc+3JhSQ1e5wahveotJDqOwvDhsE4wFLPC r9xUDp4qFJIAXfh1TrbmUhAGS9qjXSwbIVNEqX09fVKPq/yDeKsPg9XdCqcFF5uBfkJ5 92WtsD6om9tX6DXgWuumc8lU7CQvOAbpZF6XrzVKyo6VIyTLYOapgossR9JJRX+7brpa ZVzjvQpi2g5xRx5XQvr4uzTYSbKlSlcDTggU8wHphNVUEMKyF5Dt9c55Y7Ey/SRgMs2L SCFUX0mJFIrUCc+zPARkxdBfJPMnLBuRq1olQXjfQ8yRDY6k078hR0Wszs/cyHuUMvT8 5X9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si12326672ply.45.2019.08.20.08.36.09; Tue, 20 Aug 2019 08:36:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730399AbfHTPen (ORCPT + 99 others); Tue, 20 Aug 2019 11:34:43 -0400 Received: from sauhun.de ([88.99.104.3]:37420 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728283AbfHTPen (ORCPT ); Tue, 20 Aug 2019 11:34:43 -0400 Received: from localhost (p54B333DC.dip0.t-ipconnect.de [84.179.51.220]) by pokefinder.org (Postfix) with ESMTPSA id 4A90B2E40A2; Tue, 20 Aug 2019 17:34:41 +0200 (CEST) From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: Wolfram Sang , Hans de Goede , linux-kernel@vger.kernel.org Subject: [PATCH] i2c: cht-wc: drop check because i2c_unregister_device() is NULL safe Date: Tue, 20 Aug 2019 17:34:40 +0200 Message-Id: <20190820153441.7693-1-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang --- Build tested only, buildbot is happy, too. Please apply to your tree. drivers/i2c/busses/i2c-cht-wc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c index 66af44bfa67d..3e2608a65c06 100644 --- a/drivers/i2c/busses/i2c-cht-wc.c +++ b/drivers/i2c/busses/i2c-cht-wc.c @@ -363,8 +363,7 @@ static int cht_wc_i2c_adap_i2c_remove(struct platform_device *pdev) { struct cht_wc_i2c_adap *adap = platform_get_drvdata(pdev); - if (adap->client) - i2c_unregister_device(adap->client); + i2c_unregister_device(adap->client); i2c_del_adapter(&adap->adapter); irq_domain_remove(adap->irq_domain); -- 2.20.1