Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <793ce2e9b6200a033d44716749acc837aaf5e4e7.camel@linux.ibm.com>
Subject: Re: [PATCH 1/1] netfilter: nf_tables: fib: Drop IPV6 packages if
 IPv6 is disabled on boot
From:   Leonardo Bras <leonardo@linux.ibm.com>
To:     Florian Westphal <fw@strlen.de>
Cc:     netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        "David S. Miller" <davem@davemloft.net>
Date:   Tue, 20 Aug 2019 13:15:58 -0300
In-Reply-To: <20190820053607.GL2588@breakpoint.cc>
References: <20190820005821.2644-1-leonardo@linux.ibm.com>
         <20190820053607.GL2588@breakpoint.cc>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-m9cJ5dvj55slR763He6R"
User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-m9cJ5dvj55slR763He6R
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2019-08-20 at 07:36 +0200, Florian Westphal wrote:
> Wouldn't fib_netdev.c have the same problem?
Probably, but I haven't hit this issue yet.

> If so, might be better to place this test in both
> nft_fib6_eval_type and nft_fib6_eval.
I think that is possible, and not very hard to do.

But in my humble viewpoint, it looks like it's nft_fib_inet_eval() and
nft_fib_netdev_eval() have the responsibility to choose a valid
protocol or drop the package.=20
I am not sure if it would be a good move to transfer this
responsibility to nft_fib6_eval_type() and nft_fib6_eval(), so I would
rather add the same test to nft_fib_netdev_eval().

Does it make sense?

Thanks for the feedback!

Leonardo Bras


--=-m9cJ5dvj55slR763He6R
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMdeUgIzgjf6YmUyOlQYWtz9SttQFAl1cHL4ACgkQlQYWtz9S
ttQbUQ//an3s2FA0YmWznPCpuVyaRbg4KSGnPHCjofiK80uNECoyITzkXkjLAtpe
KjHFZTLAyJ88bSIXzT4Xk3qiGn3GHLVPoJKZyMqMic/kTVg2Uz+ylOl4FRGzI5uL
KYIgXLWgha1MYUCv6nhjNwWB9a6lvGMiquiwFWRdv/VtqXcEPh8YB2hTlxjH9O1E
mSQyapLF+2JLCWhj3M2dzX5TVGPPSoVmiYI2+PQpcnriTD5f4ouok+aTY0xUjLEJ
YiFGaGsbQXePVz0MZgFqyM/k+sbP+7DyBSy3qhexluK/TaM/5SE5PXihm9uXou63
w1A7kvVYQgIjSu9z3IkcWKhR5o/ePQmEVL3lu+Gj465P6XJ6k0PQo6GcEFcOKoP/
ro9XXYfCkNRddrRA4e9mpWyYGhGwbjeZzjASEtJ9B8mfXjMda/f98dGCNzrSWYQ2
QoaQ9j4HbfDEraxaPYMbyQZaqR4frsMFH0lf0y9Cyjw0zHYcTROvVM2Zn/1W65m0
ekkK9X46pZsB61qPbOHhs+8IB0YBsf7B/T7AQZRxWRhHLqp6ziUMVqD0N77kZs6D
u8eTaJMxLaE9mvEBbBdPL1fiDuqKJ5yyplPWswv7+CCUnFYDpXRybYE/xBSX3+RQ
bopDEGzVU/+iwu5U1ggkRvqaMuOpUSb2WEfTpI7X4ii2d4RZH5o=
=4h++
-----END PGP SIGNATURE-----

--=-m9cJ5dvj55slR763He6R--