Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4367157ybl; Tue, 20 Aug 2019 10:48:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqzw8BtSvgjBcVwBDzfHo2FDtyHOrp1j6os+AV4I6uKPIB3qNpYVBe0/jluh/FXq23OKmQZB X-Received: by 2002:a63:1743:: with SMTP id 3mr25030810pgx.435.1566323332766; Tue, 20 Aug 2019 10:48:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566323332; cv=none; d=google.com; s=arc-20160816; b=FQ+b6NCID2tEwdLaVZSE0vUM/yC3R7TK/wZigWjoM8em4NwzrL9o8yLy9e9j7wVJl9 bgiihjy5hK+BTiId+4ipc3IbrPhlrteEPdq35WsyaTTWoxrYpnQmxOcLhcDiD0c8Gbb2 MiihE3iIKnQCw7vayXTMmD6OrKE60z3ZyBpO9Skz4/7G1SvYobMXqyfhsOT5m3TK2rpt r0y9Tz3iY29j9gd1fZcxx2yaxSWzv+qb8B0a5jBR5nk7K4rJdjI/X1JYoaFR+1YTxKrD pi7dGPfZtgAagAfdNJTuENSc0HEcvS7BovNSl/Qv6BZfTkjpP+r1dOP67LjbCiLiY5OC q1Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2EY+Fe6YmQrVA6JgIdPQNb8uXLiBi+PaJJUIu+UXFHw=; b=x7zvXPeQ9NF4IQ0/zBNWMu0eHy2+MpsR78WJOUE+LAmBjh/t9otPKLMrMDwFrlN5Mn BIpKXflf/w1eyKNs6PMCYZSO6iXGYu2tUaUxGoFMUN+OSqkWR/vi8rxutuJb3xiVXXQI w9zhyrEMJxahO2idDzj2kQCMQMY5zFARyi8o1GxZ6MeqbgJNXuJJFtp54pJUYm/d1cre sFa9l4rzzB9OOefzJuNvzi96WgAHpUbVMo2jQFrVnP7DDTBn6YqUjC8DQpYbhv9iHruP FM753FIhXTegrCeN0/+bBYjZagUn7QoRwbm/rCpG0CZeo8Bw3xg2JOTTweRIG6y0acr0 9OYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=uW6UpkGZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si13704918pfq.58.2019.08.20.10.48.37; Tue, 20 Aug 2019 10:48:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=uW6UpkGZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730553AbfHTRp6 (ORCPT + 99 others); Tue, 20 Aug 2019 13:45:58 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:42272 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbfHTRp6 (ORCPT ); Tue, 20 Aug 2019 13:45:58 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9775933D; Tue, 20 Aug 2019 19:45:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1566323156; bh=eIm3roakiu/zu7hrvdf6nOWAH1kG1SWcjMX1AchKy68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uW6UpkGZMXbeisbLgRwTjKcqWUyTWbfy3md0VELObeF506gNOssWQ4MrRu7S9RTpm fn9uT5M0vCr5thh0YU9vDO3WAzyAjMqBUP/DfPe7FGEY1ClkHoBYux6BcLa8Go5Yd1 PgT+8HLudYOZDpAwp1kpDtHQS9gN/rxN91Ljn8h8= Date: Tue, 20 Aug 2019 20:45:50 +0300 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, koji.matsuoka.xm@renesas.com, muroya@ksk.co.jp, VenkataRajesh.Kalakodima@in.bosch.com, Harsha.ManjulaMallikarjun@in.bosch.com, linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 15/19] drm: rcar-du: Claim CMM support for Gen3 SoCs Message-ID: <20190820174550.GI10820@pendragon.ideasonboard.com> References: <20190706140746.29132-1-jacopo+renesas@jmondi.org> <20190706140746.29132-16-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190706140746.29132-16-jacopo+renesas@jmondi.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Sat, Jul 06, 2019 at 04:07:42PM +0200, Jacopo Mondi wrote: > Add CMM to the list of supported features for Gen3 SoCs that provide it: > - R8A7795 > - R8A7796 > - R8A77965 > - R8A7799x > > Leave R8A77970 out as V3M and V3H are the only Gen3 SoCs that do not > support CMM. > > Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 12 ++++++++---- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 75ab17af13a9..1e69cfa11798 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -247,7 +247,8 @@ static const struct rcar_du_device_info rcar_du_r8a7795_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(3) | BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > @@ -280,7 +281,8 @@ static const struct rcar_du_device_info rcar_du_r8a7796_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(2) | BIT(1) | BIT(0), > .routes = { > /* > @@ -309,7 +311,8 @@ static const struct rcar_du_device_info rcar_du_r8a77965_info = { > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > | RCAR_DU_FEATURE_VSP1_SOURCE > | RCAR_DU_FEATURE_INTERLACED > - | RCAR_DU_FEATURE_TVM_SYNC, > + | RCAR_DU_FEATURE_TVM_SYNC > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(3) | BIT(1) | BIT(0), > .routes = { > /* > @@ -357,7 +360,8 @@ static const struct rcar_du_device_info rcar_du_r8a77970_info = { > static const struct rcar_du_device_info rcar_du_r8a7799x_info = { > .gen = 3, > .features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK > - | RCAR_DU_FEATURE_VSP1_SOURCE, > + | RCAR_DU_FEATURE_VSP1_SOURCE > + | RCAR_DU_FEATURE_CMM, > .channels_mask = BIT(1) | BIT(0), > .routes = { > /* > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > index 1327cd0df90a..a00dccc447aa 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h > @@ -28,6 +28,7 @@ struct rcar_du_encoder; > #define RCAR_DU_FEATURE_VSP1_SOURCE BIT(1) /* Has inputs from VSP1 */ > #define RCAR_DU_FEATURE_INTERLACED BIT(2) /* HW supports interlaced */ > #define RCAR_DU_FEATURE_TVM_SYNC BIT(3) /* Has TV switch/sync modes */ > +#define RCAR_DU_FEATURE_CMM BIT(4) /* Has CMM */ > > #define RCAR_DU_QUIRK_ALIGN_128B BIT(0) /* Align pitches to 128 bytes */ > -- Regards, Laurent Pinchart