Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4493496ybl; Tue, 20 Aug 2019 12:49:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPPbB5p/KJAehnT0cbpMrR+B/iu7/BqPKV7WcVEwei020B4ewvborYAkp3lFb7MdGKTTLp X-Received: by 2002:a17:902:9686:: with SMTP id n6mr29227741plp.113.1566330571893; Tue, 20 Aug 2019 12:49:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566330571; cv=none; d=google.com; s=arc-20160816; b=swhUg9goZJKQNjkUsfFtF+mhpDY7LpEYBuJxmxvEXXEJRadmNpYfLHZI/obWjBZOda oMGukKqWdEOFVEI2GwWWjps0SNiW+44QXEiA9T+lYfyfIuKAvtMimY/kr1DCsn4LphiC 5nWXrSqXABTtL28R7tkNn68JiyTpdwP5Ispy3Wy4iVWJmPd5VW2ddSw5TJojWCMj3qbW 0wUJdpeP3GHmab/bAf4TQOcQKfJmFXIdzhLbx8xIc6qf6g+Zg/FbozeYpkdRQXvn0cBi g+aFG+goQfCN73shfDOHi5suCCu7xU55Gj7RtQ7Iii6niAzdlyTE6RTbOYmvhGT5CBt9 lqgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=V+Ry32ZgEIHen7haKhUKvt/SdTsDZBJrFK+fb8Iihwk=; b=a0TVCXMwjxEqTrAVvIMuDGhEFk07R/+pjREy9nWbWu4xAZR2PQatWRdg14HaPT+aVV fXphRUY9Pw1mVpuPNed2ThKLPM4XgTnis4zSLb1eSE4hu6GF+7tJeARBB/7Aja6/cnap mtaGS8ntcDGylw6MvnlGa4ct2Eh+QmzAziAixQjuVk+Mg5BrlzKB4Vp7wkwQHuZSWcqK yu/6KhHngNJfZTwrJYPB7fzmAB8z/1V01vrqzWMRulYaSzJvHKH971SWvCv6AZ2J3BrM +MO3fgsMDqxeQfUzwe3T0yoZ8KXk9amUirSkxWuwcjH39y1JizMeVb9ae4+tC+YqifJD DhrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 130si13805746pfb.117.2019.08.20.12.48.51; Tue, 20 Aug 2019 12:49:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730809AbfHTTpv (ORCPT + 99 others); Tue, 20 Aug 2019 15:45:51 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50312 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729409AbfHTTpu (ORCPT ); Tue, 20 Aug 2019 15:45:50 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B2E0A146F0E88; Tue, 20 Aug 2019 12:45:49 -0700 (PDT) Date: Tue, 20 Aug 2019 12:45:49 -0700 (PDT) Message-Id: <20190820.124549.2048964358332749388.davem@davemloft.net> To: decui@microsoft.com Cc: jhansen@vmware.com, stefanha@redhat.com, sgarzare@redhat.com, netdev@vger.kernel.org, sthemmin@microsoft.com, Alexander.Levin@microsoft.com, sashal@kernel.org, haiyangz@microsoft.com, kys@microsoft.com, mikelley@microsoft.com, linux-hyperv@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vsock: Fix a lockdep warning in __vsock_release() From: David Miller In-Reply-To: <1566270830-28981-1-git-send-email-decui@microsoft.com> References: <1566270830-28981-1-git-send-email-decui@microsoft.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Aug 2019 12:45:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dexuan Cui Date: Tue, 20 Aug 2019 03:14:22 +0000 > +static void __vsock_release2(struct sock *sk) Do not duplicate an entire function just to adjust some aspect of the lock debugging, please find a cleaner and more minimal way to implement this fix.