Received: by 2002:a25:8b12:0:0:0:0:0 with SMTP id i18csp4547352ybl; Tue, 20 Aug 2019 13:48:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqwd85Xl98zCo3tLyExorxTEdudNUekKq3dksWW4hE+IJRxf+n2hNRXO1E3lCelkZXHq+GnP X-Received: by 2002:a17:902:76c7:: with SMTP id j7mr29500886plt.247.1566334119223; Tue, 20 Aug 2019 13:48:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566334119; cv=none; d=google.com; s=arc-20160816; b=xVXwIDaJEZ0dNFvZcfM2GR2KAF3fH/wfdHMrsk76TpD9/yf/G1v0xUqIr9AlTyJFL6 fZaTbi6yxbw6fDb5BEhb+e8Bep2scEBkl5TTOwVCi7kLJ1VPp6URG1BhGVDC/v8QPFIb upn0pq+evqRCcB/J9P69E+fk6tZ1LNBQ/ZjnS16YyQVGeYefARn2nb3wJ5VzuIyD0Mwu hTl0HixOBcVEjC4nbitxpbFFFoe2ksBUBR/6Bs79LD4tQJ7qkXFkC2xERELRWwfMcoSy jBTrBUYCh9ViPtuNoGvgdSWLMRH3YMfzYDhrQcXpUDeQf9EwkihcIVx12hNslPnuTVEa UH0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=LpwtEqTLzLX4wmTm2Zfdu2P7CsACSbnL7oTUp1FHQmw=; b=sfKlQCja4RxuH9Eo0Cn9yv12mmuvGZXwVZ/lw7toYl7uCLwjJjkIPERMLrHiHII3Vt UfqOz9/zMaBfaFQAiavpYc4aPtJjuRCZapc1TiYgjbUf4TAamatc41ChphFYnQMXNkJI u9H4ym6wCf8J4E1/q/jtdT9+6UW1/TVjRvSOKbyRq6w4tC6A9bXYbj5ZUrH2A/kl9eKG RsleRHNk8pMSuBns7Xq6GfdnFBmKAbEuZedqKFrai9KUF3tX9vmtqTPN7Yh5d6+09V3/ 78Z95/sFeQbaW5UqI1LSCG0KGWe67H9ZSg7HmJBg0lzTgsgCxob716IRHrSZjcS7DeN2 IIaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m22si12792215pgh.190.2019.08.20.13.48.21; Tue, 20 Aug 2019 13:48:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730650AbfHTUrS (ORCPT + 99 others); Tue, 20 Aug 2019 16:47:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50840 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729156AbfHTUrS (ORCPT ); Tue, 20 Aug 2019 16:47:18 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 37C961481204E; Tue, 20 Aug 2019 13:47:17 -0700 (PDT) Date: Tue, 20 Aug 2019 13:47:06 -0700 (PDT) Message-Id: <20190820.134706.1034655132989299239.davem@davemloft.net> To: yuehaibing@huawei.com Cc: idosch@mellanox.com, jiri@mellanox.com, mcroce@redhat.com, jakub.kicinski@netronome.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] netdevsim: Fix build error without CONFIG_INET From: David Miller In-Reply-To: <20190820141446.71604-1-yuehaibing@huawei.com> References: <20190819120825.74460-1-yuehaibing@huawei.com> <20190820141446.71604-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 20 Aug 2019 13:47:17 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing Date: Tue, 20 Aug 2019 22:14:46 +0800 > If CONFIG_INET is not set, building fails: > > drivers/net/netdevsim/dev.o: In function `nsim_dev_trap_report_work': > dev.c:(.text+0x67b): undefined reference to `ip_send_check' > > Use ip_fast_csum instead of ip_send_check to avoid > dependencies on CONFIG_INET. > > Reported-by: Hulk Robot > Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support") > Signed-off-by: YueHaibing > --- > v2: use ip_fast_csum instead of ip_send_check Applied, thank you.